-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tables] Cosmos workaround for Merge/Update #17888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - thanks for this!
sdk/tables/azure-data-tables/tests/test_table_entity_cosmos_async.py
Outdated
Show resolved
Hide resolved
assert transaction_result.get_entity('batch_all_operations_together-2') is not None | ||
assert transaction_result.get_entity('batch_all_operations_together-3') is not None | ||
assert transaction_result.get_entity('batch_all_operations_together-4') is not None | ||
assert transaction_result.get_entity('batch_all_operations_together-5') is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should rename this method - it's a bit too close to client.get_entity
.
I'll have a think about this one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Maybe add a note to the changelog?
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Adding Lots by Customer (Azure#17888) * Adding Lots by Customer * Prettier fix * Fixing Semantic * Fixing Semantic * Fixing Semantic * Update consumption.json * Fixing PR comments * Deleting properties not allowed
Closes #13844