Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document translation sample slug #17989

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Update document translation sample slug #17989

merged 1 commit into from
Apr 13, 2021

Conversation

kristapratico
Copy link
Member

No description provided.

@kristapratico kristapratico self-assigned this Apr 12, 2021
@heaths
Copy link
Member

heaths commented Apr 12, 2021

Should they maybe all be updated?

heaths
heaths approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but

  1. Should probably fix 'em all.
  2. Make sure the Translator service team agrees (I'll update my PR accordingly, since this is probably a better choice you have here).

sdk/translation/azure-ai-translation-document/samples/README.md
@@ -5,7 +5,7 @@ languages:
products:
- azure
- azure-cognitive-services
- azure-document-translation
- azure-translator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably a better choice than what I did in the .NET PR, but let's find out from the service team for sure. Ultimately, they should probably request a new one if they feel it worth it. The slugs do get pretty specific, so maybe not a bad idea.

@kristapratico
Copy link
Member Author

Should they maybe all be updated?

I opened issues for all other services that had invalid slugs.

Make sure the Translator service team agrees (I'll update my PR accordingly, since this is probably a better choice you have here

Yeah going to hold on merging until we hear back from @maririos

@kristapratico kristapratico merged commit 6b640a4 into master Apr 13, 2021
@kristapratico kristapratico deleted the kristapratico-patch-1 branch April 13, 2021 16:37
iscai-msft added a commit that referenced this pull request Apr 15, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
3fd484f 
…into protocol_base

* 'master' of https://github.com/Azure/azure-sdk-for-python: (337 commits)
  [Container Registry] adding blurb about env vars to set (#17976)
  shared_requirements msrest verison update (#17938)
  Deprecate Azure-Synapse (#18027)
  add perf tests (#17519)
  Increment package version after release of azure-search-documents (#18017)
  [Communication]: Migrated python identity tests to use ARM template (#17890)
  [Container Registry] fixing up the test-resources-post script (#17883)
  [Communication]: Removed error code assertion from unauthorized phone number test (#17955)
  Add Conda Publishing (#17889)
  fix search fields (#18014)
  Sync eng/common directory with azure-sdk-tools for PR 1552 (#18011)
  [AppConfiguration] fix tests (#17917)
  updating generated code (#17874)
  Update document translation sample slug (#17989)
  update release date (#17988)
  [Communication] - SDK - Synced SMS and Phone Numbers shared folders (#17985)
  Remove unnecessary attribute access (#18007)
  [AutoRelease] t2-healthcareapis-2021-04-12-56802 (#17968)
  Revert retain. (#18004)
  Sync eng/common directory with azure-sdk-tools for PR 1553 (#18002)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 7, 2022
@debroy @debjyoti11
@roeybc @laithhisham @ushasan @hassanchawiche @shschwar @royrein @dosegal @akning-ms
CodeGen from PR 18025 in Azure/azure-rest-api-specs
4b75938 
Dev sentinel 2022 01 01 preview (Azure#18025)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-10-01-preview to version 2022-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* SourceControl API 2022-01-01-preview version - adding new attribute to SourceControl model (Azure#17849)

* SourceControl 2022-01-01-preview version change

* fix validation error

* prettified

* prettified

Co-authored-by: debjyoti11 <debjyotiroy88@gmail.com>

* New metadata API (Azure#17942)

* metadata changes

* addressed changes

* updated enum kind

* updated values as well

Co-authored-by: Roey Ben Chaim <robencha@microsoft.com>

* added new enum to kind (Azure#17994)

Co-authored-by: Roey Ben Chaim <robencha@microsoft.com>

* Add flag to rotate webhook secret (Azure#17989)

Co-authored-by: debjyoti11 <debjyotiroy88@gmail.com>

* Align definitions with stable version (Azure#17931)

* Align definitions with stable version

* align scheduled rule and template properties with stable

* Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes (Azure#17848)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

Co-authored-by: Hassan Chawiche <hassanc@microsoft.com>

* Rename system to AutoAssigned (Azure#18061)

* Rename system to AutoAssigned

* Add example to list operations

* Update API version in NRT examples

* Execute validation tools and fix results (Azure#17733)

* Execute validation tools and fic results

* Prettyfieir GetIoTById.json

* Watchlists.json-2022-01-01-preview-parameterNameChanges (reverted PR reference for files changed -> https://github.com/Azure/azure-rest-api-specs/pull/17848/files) (Azure#18085)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

* fixing type version

* Update Watchlists.json

* Update DeleteWatchlist.json

* fixing commas

Co-authored-by: Hassan Chawiche <hassanc@microsoft.com>
Co-authored-by: Usman Hasan <usman.hasan@microsoft.com>

* Done (Azure#17843)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* AutomationRules 2022-01-01-preview: Add constraints (Azure#18099)

* add contraints (alinged with the latest stable version)

Co-authored-by: debroy <debjyoti.iitkgp@gmail.com>
Co-authored-by: debjyoti11 <debjyotiroy88@gmail.com>
Co-authored-by: RoeyBC <roey.benhaim@gmail.com>
Co-authored-by: Roey Ben Chaim <robencha@microsoft.com>
Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: ushasan <69323982+ushasan@users.noreply.github.com>
Co-authored-by: Hassan Chawiche <hassanc@microsoft.com>
Co-authored-by: shschwar <55053268+shschwar@users.noreply.github.com>
Co-authored-by: Usman Hasan <usman.hasan@microsoft.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@maririos maririos Awaiting requested review from maririos

Assignees

@kristapratico kristapratico

Labels
Cognitive - Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapratico @heaths