Fix service props Metrics class #17992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
tasherif-msft
added a commit
that referenced
this pull request
May 10, 2021
* reverted share lease * Added share lease docstrings This reverts commit 8094c4e. * [Datalake] HNS Soft Delete (#17614) * generated HNS soft delete * undelete_path * deleted list_paths and config_async * lint * linter * Added get/set props * recorded tests and added models * added async prefix * recorded async tests for get and set props * removed preprod from yaml files * removed preprod from yaml files * cleaned up model name * cleaned up model name * added path helpers * fixed preprod * added the deserialize method for deleted paths * added get deleted Paths * renamed models * fixed delete directory failing tests * fixed recording for get_deleted_paths * fixed tests * fixed tests * rename * linter * linter * typing * cleaned up * renamed and cleaned up * linter and rename * linter * added test * rename deleted_path_version to deletion_id * Fixed dir prefix issue * Fixed directory prefix issue * renamed deser * reset testcase * removed whl * fixed pos arg * fixed retention * fixed docstrings * fixed test failures * added new header to detect file or dir * cleanup * fixed tests Co-authored-by: xiafu <xiafu@microsoft.com> Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com> * reran tests * reran tests * Rerecord tests (#17934) * reran tests * reran tests * changed version for datalake * Fix service properties Metrics class (#17992) * [Blob] Added QQ Parquet Format (#17855) * Added QQ Parquet * cleanup * added parquet format * added version * added parquet tests * removed comment and fixed docstrings * abs path * changed version * added qq parquet to dl * changed msrest version * added tests * recorded tests * changed version for fileshares * fixed parquet type check * added missing comma * resolved archboard feedback * removed useless imports * added metrics for datalake * added extra test * updated datalake depedency * updated datalake depedency * migrated remaining tests * parquet file fix * parquet file fix * path * path * fixed recordings for the recursive bug * Stg77 Cleanup (#18376) * STG77 Preview Cleanup * resolved more archboard feedback * privated undelete path * removed parquet format * removed parquet dialect from serialize and droped the blob dep version * removed parquet dialect from serialize and droped the blob dep version * lint * resolved feedback comments * fixed return type * skipped list deleted paths tests Co-authored-by: xiafu <xiafu@microsoft.com> Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.