Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license files consistently for all packages #19240

Closed
wants to merge 1 commit into from
Closed

Add license files consistently for all packages #19240

wants to merge 1 commit into from

Conversation

major
Copy link
Contributor

@major major commented Jun 14, 2021

Ensure each python package uploaded to pypi contains a LICENSE.txt
file along with an include line in the MANIFEST.in.

Related to Azure/azure-cli#17909

@ghost
Copy link

ghost commented Jun 14, 2021

Thank you for your contribution major! We will review the pull request and get back to you soon.

Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attestation looks fine. Thank you very much.

@major
Copy link
Contributor Author

major commented Jun 14, 2021

Attestation looks fine. Thank you very much.

Thanks! This helps a bunch for Fedora RPM packaging! 🎉

Ensure each python package uploaded to pypi contains a `LICENSE.txt`
file along with an `include` line in the `MANIFEST.in`.

Related to Azure/azure-cli#17909

Signed-off-by: Major Hayden <major@mhtx.net>
@major
Copy link
Contributor Author

major commented Jul 19, 2021

I just rebased this PR since it was pretty far behind the main branch.

@major
Copy link
Contributor Author

major commented Jul 19, 2021

@lmazuel Hello! Scott recommended checking in with you to see if this change is reasonable or if I should break this up into multiple pieces. I'm happy to help either way.

Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attestation looks fine.

@major
Copy link
Contributor Author

major commented Sep 7, 2021

Closing in favor of #20193 instead.

@major major closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants