Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Update test-resources.json for new MHSM API #19311

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 17, 2021

Due to a service change, deployments with the current ARM template now fail. This updates the resource API version and adds new required fields.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 17, 2021
@mccoyp mccoyp requested review from chlowell and schaabs as code owners June 17, 2021 21:57
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you push this to a feature branch, you can run the pipeline on that before merging to master

@mccoyp
Copy link
Member Author

mccoyp commented Jun 18, 2021

/check-enforcer reset

@mccoyp mccoyp enabled auto-merge (squash) June 21, 2021 19:50
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mccoyp
Copy link
Member Author

mccoyp commented Jun 21, 2021

/check-enforcer reset

@mccoyp
Copy link
Member Author

mccoyp commented Jun 21, 2021

/azp run python - keyvault - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp
Copy link
Member Author

mccoyp commented Jun 21, 2021

/check-enforcer override

@mccoyp mccoyp merged commit 12e4274 into Azure:main Jun 21, 2021
@mccoyp mccoyp deleted the arm-template branch June 21, 2021 23:27
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Jun 15, 2022
Feature/cplat 2022 04 04 (Azure#19467)

* set up feature branch

* Update cloud service swagger file and examples (Azure#19311)

* Update cloud service swagger file and examples

* Update cloudService.json

Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>

* move systemData object to common.json

* Add CloudServiceSlotType to swagger api 2022-04-04 (Azure#19361)

Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>

* update with prettier

* resolve readme input

* add missing example

* fix example error, update common with latest change.

* set up branch

* change folder name

* change folder name

Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com>
Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Jun 23, 2022
CloudService 2022-04-04 release  (Azure#19468)

* set up branch

* Feature/cplat 2022 04 04 (Azure#19467)

* set up feature branch

* Update cloud service swagger file and examples (Azure#19311)

* Update cloud service swagger file and examples

* Update cloudService.json

Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>

* move systemData object to common.json

* Add CloudServiceSlotType to swagger api 2022-04-04 (Azure#19361)

Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>

* update with prettier

* resolve readme input

* add missing example

* fix example error, update common with latest change.

* set up branch

* change folder name

* change folder name

Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com>
Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* prettier fix

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com>
Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants