Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding docs for engsys checks #19334

Merged
merged 6 commits into from
Jun 29, 2021
Merged

Conversation

seankane-msft
Copy link
Member

No description provided.

@seankane-msft seankane-msft linked an issue Jun 18, 2021 that may be closed by this pull request
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@seankane-msft seankane-msft marked this pull request as draft June 18, 2021 18:43
doc/dev/engsys.md Outdated Show resolved Hide resolved
doc/dev/engsys.md Outdated Show resolved Hide resolved
@seankane-msft seankane-msft self-assigned this Jun 21, 2021
doc/dev/README.md Outdated Show resolved Hide resolved
doc/eng_sys_checks.md Outdated Show resolved Hide resolved
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seankane-msft !

seankane-msft and others added 2 commits June 22, 2021 10:09
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
@seankane-msft seankane-msft marked this pull request as ready for review June 22, 2021 14:09
@seankane-msft
Copy link
Member Author

/check-enforcer override

@seankane-msft seankane-msft merged commit 792f3b1 into Azure:main Jun 29, 2021
@seankane-msft seankane-msft deleted the docs-eng branch June 29, 2021 17:47
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jul 16, 2021
* adding docs for engsys checks

* adding info about all engsys checks

* adding eng sys checks to eng sys documentation

* Update doc/eng_sys_checks.md

Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>

* Update doc/dev/README.md

Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>

Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Jun 9, 2022
[Hub Generated] Review request for Microsoft.Security to add version stable/2022-05-01 (Azure#19334)

* Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* add Microsoft.Security Settings API version 2022-05-01

Co-authored-by: Shahaf Alkaslassy <shahafal@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EngSys] Document optional ci/tests flags for PR validation
3 participants