Workspaces must be a single param #19344
Conversation
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/monitor/azure-monitor-query/tests/async/test_logs_client_async.py
Outdated
Show resolved
Hide resolved
| @@ -161,60 +162,30 @@ class LogsQueryRequest(InternalLogQueryRequest): | |||
| with either end_time or duration. | |||
| :keyword datetime end_time: The end time till which to query the data. This should be accompanied | |||
| with either start_time or duration. | |||
| :param workspace: Workspace Id to be included in the query. | |||
There was a problem hiding this comment.
no- workspace_id is the primary workspace id and additional_workpspaces is an optional kwarg - the document has both (line 153, line 165)
| :keyword request_id: The error details. | ||
| :paramtype request_id: str | ||
| :keyword headers: Dictionary of :code:`<string>`. | ||
| :paramtype headers: dict[str, str] | ||
| """ | ||
|
|
||
| def __init__(self, query, workspace, duration=None, **kwargs): | ||
| def __init__(self, query, workspace_id, duration=None, **kwargs): |
There was a problem hiding this comment.
Do we need to add it into changelog?
There was a problem hiding this comment.
good catch - yes
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - monitor - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
Fixes #19252