Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation in azure.storage.blob #20084

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Fix type annotation in azure.storage.blob #20084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b1fede
Fix type annotation for get_api_version
rnestler Aug 4, 2021
f070769
Fix type annotation in _get_match_headers
rnestler Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/storage/azure-storage-blob/azure/storage/blob/_serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@


def _get_match_headers(kwargs, match_param, etag_param):
# type: (str) -> Tuple(Dict[str, Any], Optional[str], Optional[str])
# type: (Dict[str, Any], str, str) -> Tuple(Dict[str, Any], Optional[str], Optional[str])
if_match = None
if_none_match = None
match_condition = kwargs.pop(match_param, None)
Expand Down Expand Up @@ -127,7 +127,7 @@ def get_container_cpk_scope_info(kwargs):


def get_api_version(kwargs, default):
# type: (Dict[str, Any]) -> str
# type: (Dict[str, Any], str) -> str
api_version = kwargs.pop('api_version', None)
if api_version and api_version not in _SUPPORTED_API_VERSIONS:
versions = '\n'.join(_SUPPORTED_API_VERSIONS)
Expand Down