Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Resolve mindependency check failure #20390

Closed
wants to merge 1 commit into from

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Aug 23, 2021

Due to an updated cryptography requirement for azure-identity KV packages are failing mindependency checks. azure-identity is only a dev requirement, so this is an effort to resolve the issue by bumping azure-keyvault-keys's cryptography dev requirement only (still requiring only 2.1.4 to install the package).

@ghost ghost added the KeyVault label Aug 23, 2021
@scbedd
Copy link
Member

scbedd commented Aug 24, 2021

@mccoyp I have another PR #20391 that attempts addressing this as well! @xiangyan99 raised an issue and I just haven't responded yet until my prospective fix checks out.

@mccoyp
Copy link
Member Author

mccoyp commented Aug 24, 2021

Oh nice, thank you! I figured this might not work (it evidently didn't), but your solution makes sense. I'll close this and give my thumbs-up to that PR!

@mccoyp mccoyp closed this Aug 24, 2021
@mccoyp mccoyp deleted the kv-mindep branch August 24, 2021 00:22
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Aug 29, 2022
Updated response body to "SqlPoolOperationResults_GetLocationHeaderResult" sqlPool json (Azure#20390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants