Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Changelog tool] handle PR which only contains model change #22139

Merged
merged 4 commits into from
Dec 16, 2021
Merged

[Changelog tool] handle PR which only contains model change #22139

merged 4 commits into from
Dec 16, 2021

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Dec 13, 2021 •
edited
Loading

@msyyc msyyc self-assigned this Dec 13, 2021
@msyyc msyyc requested a review from lmazuel December 13, 2021 05:38
lmazuel
lmazuel approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but I feel we should not treat removal for now.

@msyyc
Copy link
Member Author

msyyc commented Dec 16, 2021

/check-enforcer override

@msyyc msyyc merged commit 8801ffd into Azure:main Dec 16, 2021
@msyyc msyyc deleted the changelog-tool-2021-12-13 branch December 16, 2021 03:01
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Jan 4, 2022
@msyyc @hildurhodd
[Changelog tool] handle PR which only contains model change (Azure#22139
555807e 
)

* added model

* update

* sort:

* skip model-removal-only
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@msyyc @rakshith91
[Changelog tool] handle PR which only contains model change (Azure#22139
be6b3c4 
)

* added model

* update

* sort:

* skip model-removal-only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft left review comments

@lmazuel lmazuel lmazuel approved these changes

Assignees

@msyyc msyyc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msyyc @lmazuel @iscai-msft