Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Fix cspell Issues #22948

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

kashifkhan
Copy link
Member

Resolves #22672

@kashifkhan kashifkhan self-assigned this Feb 7, 2022
@check-enforcer
Copy link

check-enforcer bot commented Feb 8, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@kashifkhan kashifkhan marked this pull request as ready for review March 14, 2022 18:03
@kashifkhan kashifkhan merged commit 9657ada into Azure:main Mar 14, 2022
@kashifkhan kashifkhan deleted the search_spelling branch March 14, 2022 18:11
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 9, 2022
…into new_metrics_advisor

* 'main' of https://github.com/Azure/azure-sdk-for-python: (62 commits)
  pass polling interval 0 for playback (Azure#23514)
  [webpubsub] switch to customizations code (Azure#23504)
  [AutoRelease] t2-netapp-2022-02-11-58164(Do not merge) (Azure#23214)
  [Key Vault] Address architect feedback (Azure#23475)
  Sync eng/common directory with azure-sdk-tools for PR 2910 (Azure#23499)
  check content (Azure#23496)
  fix cspell issues (Azure#22948)
  API Key Not Being Passed On Paged Requests (Azure#23477)
  [AutoRelease] t2-labservices-2022-03-14-64385 (Azure#23492)
  [Release issue status] fix date bug and serve Python only (Azure#23491)
  [SchemaRegistry] migrate to test proxy (Azure#23438)
  [compute] update test (Azure#23456)
  update servicebus test (Azure#23401)
  Update search test (Azure#23341)
  Update resources test (Azure#23340)
  Update relay test (Azure#23339)
  Update notificationhubs test (Azure#23338)
  Update network-dns test (Azure#23337)
  update network test (Azure#23421)
  update logic (Azure#23463)
  ...
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Mar 23, 2023
Azure SignalR - Adding new api-version 2023-03-01-preview (Azure#22948)

* init 2023-03-01-preview for signalr and webpubsub. Copied from 2022-02-01

* add new api version 2023-03-01-preview

* revert changes to package-lock.json and package.json

* 1. Add restart to replica
2. replica tracedResource, subscriptionId, resourceGroup, apiVersion within commonTYpe in v5
3. return 202 for patch operation
4. add 'x-ms-long-running-operation-options' for put operation
5. Add pattern to resourceName and replicaName

* 1. Change response status code to 202 for patch
2. Fix the example naming
3. Add location header for post 202, change  'final-state-via' property to 'location' for POST

* 1. Fix example response body
2. Fix "x-ms-long-running-operation-options" for put

* 1. Fix example response body
2. Fix LocationHeader for PATCH

* 1. Remove SystemData form models inherited from "Resource"
2. Reuse trackedResource, privateEndpointConnection, privateEndpointConnectionName

* Fix default value of clientCertEnabled

* Revert privateEndpointConnection since model in common is different from ours

* Fix the resourceName pattern and example

* fix naming pattern

* 1. Add 200 for signalrRegenerate Key
2. fmt example
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Mar 23, 2023
Azure SignalR - Adding new api-version 2023-03-01-preview (Azure#22948)

* init 2023-03-01-preview for signalr and webpubsub. Copied from 2022-02-01

* add new api version 2023-03-01-preview

* revert changes to package-lock.json and package.json

* 1. Add restart to replica
2. replica tracedResource, subscriptionId, resourceGroup, apiVersion within commonTYpe in v5
3. return 202 for patch operation
4. add 'x-ms-long-running-operation-options' for put operation
5. Add pattern to resourceName and replicaName

* 1. Change response status code to 202 for patch
2. Fix the example naming
3. Add location header for post 202, change  'final-state-via' property to 'location' for POST

* 1. Fix example response body
2. Fix "x-ms-long-running-operation-options" for put

* 1. Fix example response body
2. Fix LocationHeader for PATCH

* 1. Remove SystemData form models inherited from "Resource"
2. Reuse trackedResource, privateEndpointConnection, privateEndpointConnectionName

* Fix default value of clientCertEnabled

* Revert privateEndpointConnection since model in common is different from ours

* Fix the resourceName pattern and example

* fix naming pattern

* 1. Add 200 for signalrRegenerate Key
2. fmt example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search/azure-search-documents - cspell found spelling errors in source code
2 participants