[Confidential Ledger] Remove duplicate typing

[lynshi]

Description

Fixes #23356

I ran tox -e mypy -c ../../../eng/tox/ from the sdk/confidentialledger/azure-confidentialledger folder and no more issues were shown.

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[azure-sdk]

API changes have been detected in azure-confidentialledger. You can review API changes here

API changes

-         ) -> None
+         )

[kristapratico]

I ran tox -e mypy -c ../../../eng/tox/ from the sdk/confidentialledger/azure-confidentialledger folder and no more issues were shown.

Hey @lynshi, I know this isn't obvious (we're working on changing it as part of #23351) but unless you place your package name on this list, running mypy with tox will always skip over your package and claim success. If I do add your package to the list, I see a few more errors cropping up after fixing the duplicate type signature issue. Would it be possible to add azure-confidentialledger to the mypy list and also fix these additional mypy errors in this PR?

INFO:root:Package azure-confidentialledger has opted to run mypy
azure\confidentialledger\_client.py:388: error: Item "None" of "Optional[Any]" has no attribute "transaction_id"
azure\confidentialledger\_client.py:388: error: Item "None" of "Optional[Any]" has no attribute "receipt"
azure\confidentialledger\aio\_client_base.py:88: error: Argument 1 to "AsyncBearerTokenCredentialPolicy" has incompatible type "TokenCredential"; expected "AsyncTokenCredential"
azure\confidentialledger\aio\_client.py:381: error: Item "None" of "Optional[Any]" has no attribute "transaction_id"
azure\confidentialledger\aio\_client.py:381: error: Item "None" of "Optional[Any]" has no attribute "receipt"
Found 5 errors in 3 files (checked 50 source files)

To repro:

1. Add "azure-confidentialledger" to this list
2. run ...\azure-sdk-for-python\sdk\confidentialledger\azure-confidentialledger>tox -e mypy -c ../../../eng/tox/tox.ini

[lynshi]

To repro:

1. Add "azure-confidentialledger" to this list
2. run ...\azure-sdk-for-python\sdk\confidentialledger\azure-confidentialledger>tox -e mypy -c ../../../eng/tox/tox.ini

Ah sorry, I missed that! I've made the change and fixed the errors that showed up.

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

[lynshi]

Hi @kristapratico, sorry to ping - is there a timeframe for merging? As I understand it, we'll ignore the build errors for now as the test framework has been entirely redone. GA for us is coming soon and when we introduce the GA-ready package we'll also update the tests + make the type hintings consistent.

[kristapratico]

Hi @lynshi - no timeline, I think by GA sounds good.

[ghost]

Hi @lynshi. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

[lynshi]

This will be addressed in our GA release.