[Cosmos] Update cosmos codeowners #23729

simorenoh · 2022-03-29T18:01:09Z

Adding @annatisch and @tjprescott as code owners to cosmos since they have been checking most of the big PR's already, and @JericHunter who is new to the SDK.

* Removed some stuff * Looking at constructors * Updated request * Added client close * working client creation Co-authored-by: simorenoh <simonmorenohe@gmail.com>

database read works, but ignored exception is returned: Fatal error on SSL transport NoneType has no attribute 'send' (_loop._proactor.send) RuntimeError: Event loop is closed Unclosed connector/ connection

Added methods needed to use async with when initializing client, but logs output "Exception ignored... Runtime Error: Event loop is closed"

Move branch into local fork

missing upsert and other resources

missing read_all_items and both query methods for container class

Complete item CRUD functionality - only missing queries

Query functionality and container query methods

also fixed README and added examples_async

check-enforcer · 2022-03-29T18:17:07Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

simorenoh · 2022-04-04T16:15:13Z

/azp run python - cosmos - ci

azure-pipelines · 2022-04-04T16:15:20Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

simorenoh · 2022-04-13T19:22:00Z

/check-enforcer evaluate

tjprescott · 2022-04-13T19:49:03Z

/check-enforcer override

Release app microsoft.app 2023 04 01 preview (Azure#24103) * Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * support terminationGracePeriodSeconds (Azure#23476) * Support SubPath in volume mount and mount options for azure file volume (Azure#23496) * Support SubPath in volume mount and mount options for azure file volume * update description * Add replica/container running state (Azure#23617) * add replica/container running state * spell error fix * add event trigger for Container Jobs 2023-04-01-preview (Azure#23724) * add event trigger for Container Jobs 2023-04-01-preview * prettier and avocado fix --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Resolve Comments for Event driven jobs (Azure#23729) * Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> * Swagger change for mtls and runningState (Azure#23767) * 1. Add mtls properties for managed ManagedEnvironment 2. Add running state for Revision * fix * Add ContainerApp Start/Stop for 2023-04-01-preview (Azure#23497) * Add ContainerApp Start/Stop for 2023-04-01-preview * Fix validation error * Fix validation error * Change example to add location in header * Fix lint error * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Add new source controls properties (Azure#23891) * Add new source controls properties * Update examples * fix examples * Change event trigger replica properties to executions, add polling in… (Azure#23810) * Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs * Fix validation errors * code review comments * Fix formatting errors * Code review comments * Add single execution history endpoint, refactor copy paste code for j… (Azure#23816) * Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters * Fix validation errors from ARM * Fix validation errors * Code review comments * Fix validation error * code review comments from Anand * Add springboard properties (Azure#23932) * Add springboard properties * CR comments * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <jijohn@microsoft.com> * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <jijohn@microsoft.com> --------- Co-authored-by: Jitin John <jijohn@microsoft.com> * Fix Lint issues in ContainerApps.json (Azure#24107) * Fix lint issue * Fix format issue * Fix json format issue * Fix model validation * Fix lint error * fix param (Azure#24166) Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com> --------- Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: njucz <740360112@qq.com> Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com> Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com> Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com> Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com> Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com> Co-authored-by: Zijian-Ju <53360473+Zijian-Ju@users.noreply.github.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com> Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com> Co-authored-by: Ahmed ElSayed <ahmed@elsayed.io> Co-authored-by: Jitin John <jijohn@microsoft.com> Co-authored-by: Seris370 <38371667+Seris370@users.noreply.github.com> Co-authored-by: Chenghui Yu <chenghuiyu@microsoft.com>

simorenoh and others added 30 commits August 13, 2021 13:14

initial commit

61ba8d1

Client Constructor (#20310)

15dcceb

* Removed some stuff * Looking at constructors * Updated request * Added client close * working client creation Co-authored-by: simorenoh <simonmorenohe@gmail.com>

read database

bda95c3

database read works, but ignored exception is returned: Fatal error on SSL transport NoneType has no attribute 'send' (_loop._proactor.send) RuntimeError: Event loop is closed Unclosed connector/ connection

Update simon_testfile.py

c9648ab

with coroutine

80540dc

Added methods needed to use async with when initializing client, but logs output "Exception ignored... Runtime Error: Event loop is closed"

Update simon_testfile.py

1285438

small changes

992b0cd

async with returns no exceptions

47cb688

Merge pull request #1 from Azure/simonmoreno/async

f3fa79f

Move branch into local fork

async read container

0c49739

async item read

47f4af5

cleaning up

c97c946

create item/ database methods

fcd95db

item delete working

36c5b90

docs replace functionality

44db2a2

missing upsert and other resources

upsert functionality

ec5b6ed

missing read_all_items and both query methods for container class

Merge pull request #2 from simorenoh/item-read

d63d052

Complete item CRUD functionality - only missing queries

missing query methods

5d74c8f

CRUD for udf, sproc, triggers

89fc2f7

Merge branch 'Azure:main' into async-client

fdaa880

Merge branch 'Azure:main' into async-client

3f9baf2

Merge branch 'Azure:main' into query-functionality

d6650bc

initial query logic + container methods

043dfe0

Merge branch 'async-client' into query-functionality

befdb41

Merge pull request #3 from simorenoh/query-functionality

8cffbe2

Query functionality and container query methods

missing some execution logic and tests

72de7c8

oops

5b805b8

fully working queries

8d8d0c4

small fix to query_items()

b597ca8

also fixed README and added examples_async

Update _cosmos_client_connection_async.py

18319df

simorenoh and others added 9 commits January 18, 2022 16:27

fix connection string comma

437895f

Update CHANGELOG.md

dd4b4a4

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python

79e0b28

Merge branch 'Azure:main' into main

399f8bc

fixing extra await keyword in sample

a3bd2e8

Update CHANGELOG.md

dbf1532

Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python

c275953

Update CHANGELOG.md

140b042

Update CODEOWNERS

1a0c178

simorenoh requested review from kushagraThapar, simplynaveen20, xinlian12, AlexGhiondea and jsquire as code owners March 29, 2022 18:01

ghost added the Cosmos label Mar 29, 2022

simorenoh and others added 2 commits March 29, 2022 14:02

Update CODEOWNERS

4be681c

Merge branch 'main' into update-cosmos-codeowners

4e26938

jsquire requested a review from annatisch March 29, 2022 18:06

tjprescott approved these changes Apr 1, 2022

View reviewed changes

tjprescott enabled auto-merge (squash) April 1, 2022 22:23

simorenoh requested a review from JericHunter April 6, 2022 20:14

adding Jeric

6dbb964

tjprescott merged commit 23f486b into Azure:main Apr 13, 2022

simorenoh deleted the update-cosmos-codeowners branch April 14, 2022 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cosmos] Update cosmos codeowners #23729

[Cosmos] Update cosmos codeowners #23729

simorenoh commented Mar 29, 2022 •

edited

Loading

check-enforcer bot commented Mar 29, 2022

simorenoh commented Apr 4, 2022

azure-pipelines bot commented Apr 4, 2022

simorenoh commented Apr 13, 2022

tjprescott commented Apr 13, 2022

[Cosmos] Update cosmos codeowners #23729

[Cosmos] Update cosmos codeowners #23729

Conversation

simorenoh commented Mar 29, 2022 • edited Loading

check-enforcer bot commented Mar 29, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

simorenoh commented Apr 4, 2022

azure-pipelines bot commented Apr 4, 2022

simorenoh commented Apr 13, 2022

tjprescott commented Apr 13, 2022

simorenoh commented Mar 29, 2022 •

edited

Loading