Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] fixing enum checker #24068

Merged
merged 2 commits into from
Apr 18, 2022
Merged

[pylint] fixing enum checker #24068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
779ef6b
fixing enum checker
l0lawrence Apr 18, 2022
1d26c33
extra space fix :(
l0lawrence Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/pylint_custom_plugin/pylint_guidelines_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,7 +1763,7 @@ def visit_classdef(self, node):
self._enum_uppercase(node)
# Else if it does not have a metaclass, but it is an enum class
# Check both capitalization and throw pylint error for metaclass
elif node.bases[1].name == "Enum":
elif node.bases[0].name == "str" and node.bases[1].name == "Enum":
self.add_message(
"enum-must-inherit-case-insensitive-enum-meta", node=node, confidence=None
)
Expand Down