Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] Fix failing unit tests #24287

Merged
merged 88 commits into from
May 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
61ba8d1
initial commit
simorenoh Aug 13, 2021
15dcceb
Client Constructor (#20310)
annatisch Aug 20, 2021
bda95c3
read database
simorenoh Aug 27, 2021
c9648ab
Update simon_testfile.py
simorenoh Aug 27, 2021
80540dc
with coroutine
simorenoh Aug 30, 2021
1285438
Update simon_testfile.py
simorenoh Aug 30, 2021
992b0cd
small changes
simorenoh Aug 31, 2021
47cb688
async with returns no exceptions
simorenoh Aug 31, 2021
f3fa79f
Merge pull request #1 from Azure/simonmoreno/async
simorenoh Aug 31, 2021
0c49739
async read container
simorenoh Sep 1, 2021
47f4af5
async item read
simorenoh Sep 2, 2021
c97c946
cleaning up
simorenoh Sep 3, 2021
fcd95db
create item/ database methods
simorenoh Sep 13, 2021
36c5b90
item delete working
simorenoh Sep 13, 2021
44db2a2
docs replace functionality
simorenoh Sep 16, 2021
ec5b6ed
upsert functionality
simorenoh Sep 17, 2021
d63d052
Merge pull request #2 from simorenoh/item-read
simorenoh Oct 8, 2021
5d74c8f
missing query methods
simorenoh Oct 11, 2021
89fc2f7
CRUD for udf, sproc, triggers
simorenoh Oct 12, 2021
fdaa880
Merge branch 'Azure:main' into async-client
simorenoh Oct 12, 2021
3f9baf2
Merge branch 'Azure:main' into async-client
simorenoh Oct 12, 2021
d6650bc
Merge branch 'Azure:main' into query-functionality
simorenoh Oct 12, 2021
043dfe0
initial query logic + container methods
simorenoh Oct 13, 2021
befdb41
Merge branch 'async-client' into query-functionality
simorenoh Oct 13, 2021
8cffbe2
Merge pull request #3 from simorenoh/query-functionality
simorenoh Oct 13, 2021
72de7c8
missing some execution logic and tests
simorenoh Oct 21, 2021
5b805b8
oops
simorenoh Oct 21, 2021
8d8d0c4
fully working queries
simorenoh Oct 22, 2021
b597ca8
small fix to query_items()
simorenoh Oct 22, 2021
18319df
Update _cosmos_client_connection_async.py
simorenoh Oct 22, 2021
162c44d
Update _cosmos_client_connection.py
simorenoh Oct 22, 2021
ebbac51
documentation update
simorenoh Oct 22, 2021
43f78e6
Merge branch 'Azure:main' into main
simorenoh Oct 22, 2021
470aa5b
updated MIT dates and get_user_client() description
simorenoh Oct 22, 2021
74da690
Update CHANGELOG.md
simorenoh Oct 22, 2021
7104d63
Merge branch 'Azure:main' into main
simorenoh Oct 25, 2021
20718c7
Delete simon_testfile.py
simorenoh Oct 25, 2021
d825eaa
Merge pull request #4 from simorenoh/async-client
simorenoh Oct 25, 2021
e3c27a5
leftover retry utility
simorenoh Oct 25, 2021
3b778ad
Update README.md
simorenoh Oct 25, 2021
c6e352e
docs and removed six package
simorenoh Oct 28, 2021
8971a25
Merge remote-tracking branch 'upstream/main'
simorenoh Oct 28, 2021
52736ac
changes based on comments
simorenoh Nov 4, 2021
ad98039
small change in type hints
simorenoh Nov 4, 2021
f76c595
updated readme
simorenoh Nov 9, 2021
3f02a65
fixes based on conversations
simorenoh Nov 10, 2021
e719869
added missing type comments
simorenoh Nov 11, 2021
d03ee05
Merge branch 'Azure:main' into main
simorenoh Nov 11, 2021
02c52ee
update changelog for ci pipeline
simorenoh Nov 23, 2021
2cb4551
added typehints, moved params into keywords, added decorators, made _…
simorenoh Nov 29, 2021
cf20d35
changes based on sync with central sdk
simorenoh Dec 2, 2021
f456817
remove is_system_key from scripts (only used in execute_sproc)
simorenoh Dec 3, 2021
ea9bd16
Revert "remove is_system_key from scripts (only used in execute_sproc)"
simorenoh Dec 3, 2021
709d2eb
async script proxy using composition
simorenoh Dec 3, 2021
3277dd8
pylint
simorenoh Dec 3, 2021
a57cb4d
capitalized constants
simorenoh Dec 6, 2021
014578b
Apply suggestions from code review
simorenoh Dec 6, 2021
0d79695
closing python code snippet
simorenoh Dec 6, 2021
fdabea1
last doc updates
simorenoh Dec 7, 2021
016d0dd
Update sdk/cosmos/azure-cosmos/CHANGELOG.md
tjprescott Dec 7, 2021
8228aa9
version update
simorenoh Dec 7, 2021
7ae1cd0
Merge branch 'Azure:main' into main
simorenoh Dec 13, 2021
7e8e953
cosmos updates for release
simorenoh Dec 13, 2021
99997e9
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
simorenoh Jan 12, 2022
f446308
Merge branch 'Azure-main'
simorenoh Jan 12, 2022
bc466d8
Merge branch 'Azure-main'
simorenoh Jan 12, 2022
bca2da7
Merge branch 'Azure:main' into main
simorenoh Jan 13, 2022
437895f
fix connection string comma
simorenoh Jan 18, 2022
dd4b4a4
Update CHANGELOG.md
simorenoh Jan 18, 2022
79e0b28
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python
simorenoh Jan 25, 2022
399f8bc
Merge branch 'Azure:main' into main
simorenoh Jan 25, 2022
a3bd2e8
fixing extra await keyword in sample
simorenoh Feb 25, 2022
dbf1532
Update CHANGELOG.md
simorenoh Feb 25, 2022
c275953
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python
simorenoh Mar 10, 2022
140b042
Update CHANGELOG.md
simorenoh Mar 10, 2022
426a616
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python
simorenoh Apr 5, 2022
7c551dc
Merge branch 'Azure:main' into main
simorenoh Apr 6, 2022
0678376
Merge branch 'Azure:main' into main
simorenoh Apr 6, 2022
6830ed6
Merge branch 'Azure:main' into main
simorenoh Apr 28, 2022
b2e9c92
first round of fixes
simorenoh May 3, 2022
6d5f921
Update test_config.py
simorenoh May 3, 2022
6e2e9db
round 2
simorenoh May 4, 2022
9975b19
raising failed result in get_Database_accounts
simorenoh May 5, 2022
6c13409
small changes
simorenoh May 10, 2022
1af63f2
more small fixes
simorenoh May 11, 2022
da17adb
Update test_query.py
simorenoh May 12, 2022
1953c90
Update test_query.py
simorenoh May 12, 2022
94c1bda
Update _global_endpoint_manager.py
simorenoh May 12, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/cosmos/azure-cosmos/azure/cosmos/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ def IsItemContainerLink(link): # pylint: disable=too-many-return-statements


def GetItemContainerInfo(self_link, alt_content_path, id_from_response):
"""Given the self link and alt_content_path from the reponse header and
"""Given the self link and alt_content_path from the response header and
result extract the collection name and collection id.

Every response header has an alt-content-path that is the owner's path in
Expand Down
21 changes: 5 additions & 16 deletions sdk/cosmos/azure-cosmos/test/test_aad.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@
from io import StringIO

import azure.cosmos.cosmos_client as cosmos_client
from azure.cosmos import exceptions
from azure.identity import ClientSecretCredential
from azure.core import exceptions
from azure.cosmos import exceptions, PartitionKey
from azure.core.credentials import AccessToken
import test_config

Expand Down Expand Up @@ -114,19 +112,10 @@ class AadTest(unittest.TestCase):
@classmethod
def setUpClass(cls):
cls.client = cosmos_client.CosmosClient(cls.host, cls.masterKey)
cls.database = test_config._test_config.create_database_if_not_exist(cls.client)
cls.container = test_config._test_config.create_collection_if_not_exist_no_custom_throughput(cls.client)

def test_wrong_credentials(self):
wrong_aad_credentials = ClientSecretCredential(
"wrong_tenant_id",
"wrong_client_id",
"wrong_client_secret")

try:
cosmos_client.CosmosClient(self.host, wrong_aad_credentials)
except exceptions.ClientAuthenticationError as e:
print("Client successfully failed to authenticate with message: {}".format(e.message))
cls.database = cls.client.create_database_if_not_exists(test_config._test_config.TEST_DATABASE_ID)
cls.container = cls.database.create_container_if_not_exists(
id=test_config._test_config.TEST_COLLECTION_SINGLE_PARTITION_ID,
partition_key=PartitionKey(path="/id"))

def test_emulator_aad_credentials(self):
if self.host != 'https://localhost:8081/':
Expand Down
12 changes: 5 additions & 7 deletions sdk/cosmos/azure-cosmos/test/test_client_user_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,12 @@
class TestClientUserAgent(unittest.TestCase):

async def test_client_user_agent(self):
client_sync = sync_client.CosmosClient(url=_test_config.host, credential=_test_config.masterKey)
client_async = async_client.CosmosClient(url=_test_config.host, credential=_test_config.masterKey)
async with async_client.CosmosClient(url=_test_config.host, credential=_test_config.masterKey) as client_async:
client_sync = sync_client.CosmosClient(url=_test_config.host, credential=_test_config.masterKey)

self.assertTrue(client_sync.client_connection._user_agent.startswith("azsdk-python-cosmos/"))
self.assertTrue(client_async.client_connection._user_agent.startswith("azsdk-python-cosmos-async/"))
self.assertTrue(client_async.client_connection._user_agent != client_sync.client_connection._user_agent)

await client_async.close()
self.assertTrue(client_sync.client_connection._user_agent.startswith("azsdk-python-cosmos/"))
self.assertTrue(client_async.client_connection._user_agent.startswith("azsdk-python-cosmos-async/"))
self.assertTrue(client_async.client_connection._user_agent != client_sync.client_connection._user_agent)


if __name__ == "__main__":
Expand Down
37 changes: 8 additions & 29 deletions sdk/cosmos/azure-cosmos/test/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ class _test_config(object):
connectionPolicy = documents.ConnectionPolicy()
connectionPolicy.DisableSSLVerification = True

global_host = '[YOUR_GLOBAL_ENDPOINT_HERE]'
write_location_host = '[YOUR_WRITE_ENDPOINT_HERE]'
read_location_host = '[YOUR_READ_ENDPOINT_HERE]'
read_location2_host = '[YOUR_READ_ENDPOINT2_HERE]'
global_masterKey = '[YOUR_KEY_HERE]'
global_host = os.getenv('GLOBAL_ACCOUNT_HOST', host)
write_location_host = os.getenv('WRITE_LOCATION_HOST', host)
read_location_host = os.getenv('READ_LOCATION_HOST', host)
read_location2_host = os.getenv('READ_LOCATION_HOST2', host)
global_masterKey = os.getenv('GLOBAL_ACCOUNT_KEY', masterKey)

write_location = '[YOUR_WRITE_LOCATION_HERE]'
read_location = '[YOUR_READ_LOCATION_HERE]'
read_location2 = '[YOUR_READ_LOCATION2_HERE]'
write_location = os.getenv('WRITE_LOCATION', host)
read_location = os.getenv('READ_LOCATION', host)
read_location2 = os.getenv('READ_LOCATION2', host)

THROUGHPUT_FOR_5_PARTITIONS = 30000
THROUGHPUT_FOR_1_PARTITION = 400
Expand Down Expand Up @@ -84,16 +84,6 @@ def create_database_if_not_exist(cls, client):
cls.IS_MULTIMASTER_ENABLED = client.get_database_account()._EnableMultipleWritableLocations
return cls.TEST_DATABASE

@classmethod
def create_database_if_not_exist_with_throughput(cls, client, throughput):
# type: (CosmosClient) -> Database
if cls.TEST_DATABASE is not None:
return cls.TEST_DATABASE
cls.try_delete_database(client)
cls.TEST_DATABASE = client.create_database(id=cls.TEST_THROUGHPUT_DATABASE_ID, offer_throughput=throughput)
cls.IS_MULTIMASTER_ENABLED = client.get_database_account()._EnableMultipleWritableLocations
return cls.TEST_DATABASE

@classmethod
def try_delete_database(cls, client):
# type: (CosmosClient) -> None
Expand Down Expand Up @@ -131,17 +121,6 @@ def create_multi_partition_collection_with_custom_pk_if_not_exist(cls, client):
cls.remove_all_documents(cls.TEST_COLLECTION_MULTI_PARTITION_WITH_CUSTOM_PK, True)
return cls.TEST_COLLECTION_MULTI_PARTITION_WITH_CUSTOM_PK

@classmethod
def create_collection_if_not_exist_no_custom_throughput(cls, client):
# type: (CosmosClient) -> Container
database = cls.create_database_if_not_exist(client)
collection_id = cls.TEST_COLLECTION_SINGLE_PARTITION_ID

document_collection = database.create_container_if_not_exists(
id=collection_id,
partition_key=PartitionKey(path="/id"))
return document_collection

@classmethod
def create_collection_with_required_throughput(cls, client, throughput, use_custom_partition_key):
# type: (CosmosClient, int, boolean) -> Container
Expand Down
27 changes: 1 addition & 26 deletions sdk/cosmos/azure-cosmos/test/test_crud.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,7 @@ def setUpClass(cls):
cls.client = cosmos_client.CosmosClient(cls.host, cls.masterKey, connection_policy=cls.connectionPolicy)
cls.databaseForTest = cls.configs.create_database_if_not_exist(cls.client)

def setUp(self):
self.client = cosmos_client.CosmosClient(self.host, self.masterKey, "Session",
connection_policy=self.connectionPolicy)

def test_database_crud(self):
# read databases.
databases = list(self.client.list_databases())
Expand Down Expand Up @@ -1907,33 +1905,10 @@ def test_client_request_timeout_when_connection_retry_configuration_specified(se
cosmos_client.CosmosClient(CRUDTests.host, CRUDTests.masterKey, "Session", connection_policy=connection_policy)

def test_client_connection_retry_configuration(self):
total_time_for_two_retries = self.initialize_client_with_connection_urllib_retry_config(2)
total_time_for_three_retries = self.initialize_client_with_connection_urllib_retry_config(3)
self.assertGreater(total_time_for_three_retries, total_time_for_two_retries)

total_time_for_two_retries = self.initialize_client_with_connection_core_retry_config(2)
total_time_for_three_retries = self.initialize_client_with_connection_core_retry_config(3)
self.assertGreater(total_time_for_three_retries, total_time_for_two_retries)

def initialize_client_with_connection_urllib_retry_config(self, retries):
retry_policy = Retry(
total=retries,
read=retries,
connect=retries,
backoff_factor=0.3,
status_forcelist=(500, 502, 504)
)
start_time = time.time()
try:
cosmos_client.CosmosClient(
"https://localhost:9999",
CRUDTests.masterKey,
"Session",
connection_retry_policy=retry_policy)
self.fail()
except AzureError as e:
end_time = time.time()
return end_time - start_time

def initialize_client_with_connection_core_retry_config(self, retries):
start_time = time.time()
Expand Down
2 changes: 0 additions & 2 deletions sdk/cosmos/azure-cosmos/test/test_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
#SOFTWARE.

import unittest
import uuid
import pytest
import azure.cosmos.documents as documents
import azure.cosmos.cosmos_client as cosmos_client
import test_config
import os
Expand Down
Loading