Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] [ADLA] - Catalog - Support list table fragment and table preview #2594

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] [ADLA] - Catalog - Support list table fragment and table preview #2594

wants to merge 2 commits into from

Conversation

idear1203
Copy link
Contributor

@idear1203 idear1203 requested a review from lmazuel as a code owner May 21, 2018 11:34
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@idear1203
Copy link
Contributor Author

idear1203 commented May 21, 2018 •
edited
Loading

@lmazuel, please DO NOT merge this PR. I will add some tests for table preview and table partition preview soon.

Dongwei Wang added 2 commits May 21, 2018 04:40
[ADLA] - Cleaning up job.json
a33a038
[ADLA] - Catalog - Add new APIs
652b308 
* Support listing table fragments
* Support table preview and table partition preview
@idear1203 idear1203 force-pushed the adla_support_for_table_preview_and_list_table_fragments branch from a95e4ff to 652b308 Compare May 21, 2018 11:57
@idear1203 idear1203 changed the title [ADLA] - Catalog - Add new Catalog APIs [ADLA] - Catalog - Support list table fragment and table preview May 21, 2018
@lmazuel lmazuel changed the title [ADLA] - Catalog - Support list table fragment and table preview [DO NOT MERGE] [ADLA] - Catalog - Support list table fragment and table preview May 25, 2018
@lmazuel
Copy link
Member

lmazuel commented May 25, 2018

@idear1203 If this PR includes breaking changes, I suggest you to use the latest Autorest.Python 3.x adding to your generation --use=@microsoft.azure/autorest.python@~3.0.

This is the new standard, but introduces a few breaking changes (see Network 2.0.0 ChangeLog).

@idear1203
Copy link
Contributor Author

Thanks, I will take a look soon.

@idear1203
Copy link
Contributor Author

There are some issues on tests. I will reopen this PR when tests are ready

@idear1203 idear1203 closed this Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idear1203 @azuresdkci @lmazuel