Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Merge hotfix/keyvault-verify with main #26384

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Sep 22, 2022

Description

Merges the latest release branch (which contains the changes from #26141) with main.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Sep 22, 2022
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@mccoyp mccoyp marked this pull request as ready for review September 22, 2022 02:37
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 22, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-keyvault-administration
azure-keyvault-certificates
azure-keyvault-keys
azure-keyvault-secrets

@mccoyp mccoyp merged commit fe68412 into Azure:main Sep 22, 2022
@mccoyp mccoyp deleted the hotfix/kv-patches branch September 22, 2022 17:50
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 30, 2023
Support ParquetReadSettings In DataFactory And Synapse For Bug Fix (Azure#26384)

* [Synapse]Fix Credential OperationId Not UnifiedIssue

* Revert "[Synapse]Fix Credential OperationId Not UnifiedIssue"

This reverts commit 83eef9f5a22bc7796d8b5ad51cd2077d2ac8a0e0.

* Support ParquetReadSettings In ADF And Synapse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants