Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR cognitiveservices/data-plane/ComputerVision] ComputerVision: bug fixes for /describe and /analyze [breaking] #2990

Conversation

AutorestCI
Copy link
Contributor

ComputerVision: bug fixes for /describe and /analyze

* Inconsistent argument type for `/analyze?details=...` between URL and stream methods
* BingIU imagetype return values needs to be integral
* Description `maxCandidates` argument needs to be integral
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jul 24, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-cognitiveservices-vision-computervision

You can install the package azure-cognitiveservices-vision-computervision of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3486#egg=azure-cognitiveservices-vision-computervision&subdirectory=azure-cognitiveservices-vision-computervision"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3486#egg=azure-cognitiveservices-vision-computervision&subdirectory=azure-cognitiveservices-vision-computervision"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3486
  • pip install -e ./azure-cognitiveservices-vision-computervision

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3486
  • pip wheel --no-deps ./azure-cognitiveservices-vision-computervision

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Jul 24, 2018

Codecov Report

Merging #2990 into restapi_auto_cognitiveservices/data-plane/ComputerVision will increase coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@                                     Coverage Diff                                      @@
##           restapi_auto_cognitiveservices/data-plane/ComputerVision    #2990      +/-   ##
============================================================================================
+ Coverage                                                     56.43%   56.97%   +0.54%     
============================================================================================
  Files                                                          8413     7804     -609     
  Lines                                                        172375   160296   -12079     
============================================================================================
- Hits                                                          97274    91334    -5940     
+ Misses                                                        75101    68962    -6139
Impacted Files Coverage Δ
...re/mgmt/compute/v2018_04_01/models/resource_py3.py 45.45% <0%> (-54.55%) ⬇️
...t/resource/resources/resource_management_client.py 70.22% <0%> (-15.67%) ⬇️
...azure/mgmt/media/models/envelope_encryption_py3.py 44.44% <0%> (-10.11%) ⬇️
...dia/azure/mgmt/media/models/envelope_encryption.py 44.44% <0%> (-10.11%) ⬇️
...source/azure/mgmt/resource/policy/policy_client.py 68.67% <0%> (-8.1%) ⬇️
...mgmt/resource/subscriptions/subscription_client.py 93.18% <0%> (-3.19%) ⬇️
.../media/models/streaming_locator_content_key_py3.py 41.66% <0%> (-2.78%) ⬇️
...mgmt/media/models/streaming_locator_content_key.py 41.66% <0%> (-2.78%) ⬇️
...te/azure/mgmt/compute/compute_management_client.py 56.12% <0%> (-2.53%) ⬇️
...zure-mgmt-media/azure/mgmt/media/models/job_py3.py 38.46% <0%> (-1.54%) ⬇️
... and 631 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e23e68...9db4907. Read the comment docs.

@AutorestCI AutorestCI merged commit 074f39e into restapi_auto_cognitiveservices/data-plane/ComputerVision Jul 30, 2018
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #2978

@lmazuel lmazuel deleted the restapi_auto_3486 branch August 1, 2018 23:23
lmazuel pushed a commit that referenced this pull request Mar 9, 2019
* Generated from d796a072098d20051200552d7cbd6608587ffd23 (#2951)

Enable Computer Vision Client to customize endpoint.

* Generated from a3c7072f01f807edbb028085a23278d6f7980fa1 (#2990)

ComputerVision: bug fixes for /describe and /analyze

* Inconsistent argument type for `/analyze?details=...` between URL and stream methods
* BingIU imagetype return values needs to be integral
* Description `maxCandidates` argument needs to be integral

* [AutoPR cognitiveservices/data-plane/ComputerVision] Split Ocr out into own Swagger file (#3543)

* Generated from 0dc03413967addc6fb33eba01bf4b8074f5fe91a

Split Ocr out

* Packaging update of azure-cognitiveservices-vision-computervision

* [AutoPR cognitiveservices/data-plane/ComputerVision] Rename examples to match generated names (#3541)

* Generated from 5aa27bd9abb8f6f416b054d64536ee2f7175f662

Rename examples to match generated names

* Packaging update of azure-cognitiveservices-vision-computervision

* Generated from 5aa27bd9abb8f6f416b054d64536ee2f7175f662

Rename examples to match generated names

* [AutoPR cognitiveservices/data-plane/ComputerVision]  Add areaOfInterest and detectObject to CV API (#3997)

* Generated from 0bc892729baf0d049695c873e9afe139211c259d

 Add areaOfInterest and detectObject

* Replace the current swagger with an auto-generated one.
* Add example files for areaOfInterest and detectObject.
* Fix example validation errors for analyze and describe.
* A few fixes for generating java sdk

* Packaging update of azure-cognitiveservices-vision-computervision

* Packaging update of azure-cognitiveservices-vision-computervision

* Generated from 66af0936fc20f7164f70de9d36271b12fbc2a5c7 (#2985)

Remove basePath from Computer Vision 2.0 swagger.

* Update version.py

* Update sdk_packaging.toml

* Packaging update of azure-cognitiveservices-vision-computervision

* [AutoPR cognitiveservices/data-plane/ComputerVision] Analyze brands (#4294)

* Generated from 0ac968f914274f0f98612a60ac4f8998a60ff1af

Analyze brands

* Packaging update of azure-cognitiveservices-vision-computervision

* [AutoPR cognitiveservices/data-plane/ComputerVision] [Computer Vision] Add read to CV OCR API. (#4473)

* Generated from cbcb8cc3c280c9725bca0f4e0feb4bfc57b677ec

Add read to OCR API.

* Packaging update of azure-cognitiveservices-vision-computervision

* Generated from 51742b3e212c2e900ed5c24f7c351fa7f896d25e

Mark asyncBatchAnalyze as long running operation.

* Generated from b047a112a2c4cddaa54605d5de6a7bc3faab38c7

Update page property.

* Packaging update of azure-cognitiveservices-vision-computervision

* 0.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants