Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicite log procerros env var #31740

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

jeremydvoss
Copy link
Member

Description

Copy of microsoft/ApplicationInsights-Python#311

We are now leveraging OT env vars for our configuration instead of custom ones. Confirmed that OT sdk uses OTEL_BLRP_SCHEDULE_DELAY as specified here in the usage docs.

Fixes microsoft/ApplicationInsights-Python#265

PR that added these env vars to OT sdk: open-telemetry/opentelemetry-python#3237

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@jeremydvoss jeremydvoss marked this pull request as ready for review August 21, 2023 18:47
@jeremydvoss jeremydvoss requested a review from lmazuel as a code owner August 21, 2023 18:47
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@jeremydvoss jeremydvoss merged commit 374a8ce into Azure:main Aug 21, 2023
@jeremydvoss jeremydvoss mentioned this pull request Aug 25, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove logging export validation and env var logic once it is added to OTel SDK
3 participants