Fix de/serialization bugs in FeatureFlagConfigurationSetting #34852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
App Configuration
YalinLi0312
requested review from
jsquire,
kinelski,
annatisch,
HarshaNalluru,
xiangyan99,
mssfang and
minhanh-phan
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
xiangyan99
reviewed
Mar 20, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 20, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 20, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 21, 2024
...onfiguration/azure-appconfiguration/azure/appconfiguration/_azure_appconfiguration_client.py
Show resolved
Hide resolved
xiangyan99
reviewed
Mar 21, 2024
sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py
Outdated
Show resolved
Hide resolved
xiangyan99
approved these changes
Mar 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Resolving bugs about
FeatureFlagConfigurationSettingthat reported in Feature Flag description not being set #34771 and Custom Fields removed from FeatureFlagConfigurationSetting #34545Creating a
FeatureFlagConfigurationSettingwith the propertyenableddefault valueNonewill cause an error when checking in portal while no error in service response. Based on the definition in this schema(link), changed the default value toFalse.Addressing docstring about custom error type imports.
Addressing type hints.