Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR network/resource-manager] Fix errors with ddosCustomPolicy.json #4143

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

AutorestCI
Copy link
Contributor

Add ddosCustomPolicy.json to readme.md and fix spec errors
@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #4143 into restapi_auto_network/resource-manager will increase coverage by 3.79%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           restapi_auto_network/resource-manager    #4143      +/-   ##
=========================================================================
+ Coverage                                  50.24%   54.03%   +3.79%     
=========================================================================
  Files                                       6174     9797    +3623     
  Lines                                     168903   207003   +38100     
=========================================================================
+ Hits                                       84868   111861   +26993     
- Misses                                     84035    95142   +11107
Impacted Files Coverage Δ
...re/mgmt/network/v2018_11_01/operations/__init__.py 100% <100%> (ø) ⬆️
...18_11_01/models/network_management_client_enums.py 100% <100%> (ø) ⬆️
...t/network/v2018_11_01/network_management_client.py 89.85% <100%> (+0.09%) ⬆️
.../azure/mgmt/network/v2018_11_01/models/__init__.py 100% <100%> (+44.86%) ⬆️
...1_01/operations/ddos_custom_policies_operations.py 20.83% <20.83%> (ø)
...rk/azure/mgmt/network/network_management_client.py 23.44% <28.57%> (+2.93%) ⬆️
...18_11_01/models/protocol_custom_settings_format.py 44.44% <44.44%> (ø)
...1_01/models/protocol_custom_settings_format_py3.py 44.44% <44.44%> (ø)
...t/network/v2018_11_01/models/ddos_custom_policy.py 45.45% <45.45%> (ø)
...twork/v2018_11_01/models/ddos_custom_policy_py3.py 45.45% <45.45%> (ø)
... and 3752 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a7188...9086d83. Read the comment docs.

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jan 9, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-network

You can install the package azure-mgmt-network of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5008#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5008#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5008
  • pip install -e ./azure-mgmt-network

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5008
  • pip wheel --no-deps ./azure-mgmt-network

Direct download

Your files can be directly downloaded here:

Add ddosCustomPolicy.json to readme.md and fix spec errors
Add ddosCustomPolicy.json to readme.md and fix spec errors
@AutorestCI AutorestCI merged commit 2b04b9c into restapi_auto_network/resource-manager Jan 9, 2019
@AutorestCI AutorestCI deleted the restapi_auto_5008 branch January 9, 2019 22:07
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #4141

lmazuel pushed a commit that referenced this pull request Jan 15, 2019
* Generated from f4847630d0ac480f6c18a43cc92d3e5798ab14bb (#4133)

Fix duplicate path in old Network API version

* [AutoPR network/resource-manager] Fix errors with ddosCustomPolicy.json (#4143)

* Generated from f786e806eeb7e1217a996e89ba30fb7f230a4b8b

Add ddosCustomPolicy.json to readme.md and fix spec errors

* Generated from dbd13ad4dd6a402b16ce899c7c6915e147405b65

Add ddosCustomPolicy.json to readme.md and fix spec errors

* Generated from dbd13ad4dd6a402b16ce899c7c6915e147405b65

Add ddosCustomPolicy.json to readme.md and fix spec errors

* 2.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants