-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce PR test matrix to python 2.7, 3.5 and 3.8 #9031
Reduce PR test matrix to python 2.7, 3.5 and 3.8 #9031
Conversation
@weshaggard : I have updated this PR as per your suggestion to create test matrix within one yml itself. |
OSVmImage: 'ubuntu-16.04' | ||
PythonVersion: '3.6' | ||
CoverageArg: '' | ||
RunForPR: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters too much but can we get away with out listing the CoverageARg and RunForPr = false entries? It would help cut down on the size of this matrix table.
-e ../../../tools/azure-sdk-tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome this looks a lot better. I added one comment about potential clean-up if possible.
PR will run test only for 2.7, 3.5 and 3.8
CI and live test will continue to run for all versions as earlier.