Add SafeDebug trait derive macro #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeDebug is really just a marker trait. The associated derive macro implements `Debug` in a way to reduce potentially leaking PII. Currently it just outputs the struct or enum name with the non-exhaustive finish e.g., `MyModel { .. }` but we will expand that later.
Relates to Azure#1707
heaths
requested review from
RickWinter,
ronniegeraghty and
LarryOsterman
as code owners
|
@JeffreyRichter @RickWinter this corresponds to the Rust guidelines I just merged upon Jeffrey's approval. |
LarryOsterman
approved these changes
Nov 20, 2024
JeffreyRichter
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeDebug is really just a marker trait. The associated derive macro implements
Debugin a way to reduce potentially leaking PII. Currently it just outputs the struct or enum name with the non-exhaustive finish e.g.,MyModel { .. }but we will expand that later.Relates to #1707