Remove builder support from azure_core::ClientOptions #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
approved these changes
Dec 5, 2024
We changed the guidelines a while ago, but I hadn't yet gotten around to removing the now-unnecessary code. I need it for test-proxy work now.
heaths
force-pushed
the
client-options
branch
from
3e0ab7a to
4fd6a92
Compare
heaths
requested review from
Pilchie,
kirankumarkolli,
tvaron3,
FabianMeiswinkel and
kundadebdatta
as code owners
RickWinter
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the guidelines a while ago, but I hadn't yet gotten around to removing the now-unnecessary code. I need it for test-proxy work now.