Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eng/common] New-TestResources.ps1 fails when run from pwsh on zsh #1932

Closed
scbedd opened this issue Aug 24, 2021 · 6 comments
Closed

[eng/common] New-TestResources.ps1 fails when run from pwsh on zsh #1932

scbedd opened this issue Aug 24, 2021 · 6 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Aug 24, 2021

@maorleger is hitting an issue that looks like

PS /home/mleger/workspace/azure-sdk-for-js> .\eng\common\TestResources\New-TestResources.ps1 -ServiceDirectory 'keyvault' -BaseName "malegetrcsmpl" 
09:53:44 - Using subscription 'Azure SDK Developer Playground (faa080af-c1d8-40ad-9cce-e1a450ca5b57)'
09:53:44 - TestApplicationId was not specified; creating a new service principal in subscription 'faa080af-c1d8-40ad-9cce-e1a450ca5b57'
New-AzADServicePrincipal: /home/mleger/workspace/azure-sdk-for-js/eng/common/TestResources/New-TestResources.ps1:292:46
Line |
 292 |  … Principal = New-AzADServicePrincipal -Role Owner -Scope "/subscriptio …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Values of identifierUris property must use a verified domain of the organization or its subdomain: 'http://azure-powershell-08-20-2021-16-53-44'

This only occurs when running pwsh from a zsh WSL terminal.

Instructions on how to set up that environment

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Aug 24, 2021
@hallipr hallipr self-assigned this Aug 24, 2021
@annelo-msft
Copy link
Member

annelo-msft commented Aug 26, 2021

I am seeing the same issue in PowerShell 7.1.2

image

And in PowerShell 7.1.4

@annelo-msft
Copy link
Member

The call to New-AzADServicePrincipal is failing:

image

@hallipr
Copy link
Member

hallipr commented Aug 27, 2021

@annelo-msft Do you know why the display name is being used as a uri or being compared in uri form to a verified domain? I can't find any documentation that would indicate that the display name has any functional map to a domain name.

@annelo-msft
Copy link
Member

@hallipr, I do not, this is the piece that @pakrym figured out. @pakrym, do you know?

@pakrym
Copy link
Contributor

pakrym commented Aug 27, 2021

@annelo-msft Do you know why the display name is being used as a uri or being compared in uri form to a verified domain? I can't find any documentation that would indicate that the display name has any functional map to a domain name.

It seems it does. The uri is inferred from the display name.

@weshaggard
Copy link
Member

I believe this has been fixed by #1944 so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

5 participants