Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test principal creation succeeds properly #1944

Merged
1 commit merged into from
Aug 27, 2021

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Aug 26, 2021

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
Copy link
Member Author

scbedd commented Aug 27, 2021

Trying out a pipeline that uses New-TestResources.ps1

Green. Doing a template release run just to ensure I'm not missing anything, then starting the merge process across the repos.

@ghost
Copy link

ghost commented Aug 27, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 04e9623 into Azure:main Aug 27, 2021
@JoshLove-msft
Copy link
Member

JoshLove-msft commented Aug 30, 2021

I think this breaks when an already existing baseName is used, whether passed explicitly or defaulted:

New-AzADServicePrincipal: C:\Users\jolov\src\r\Azure\azure-sdk-for-net\eng\common\TestResources\New-TestResources.ps1:292
Line |
292 | … Principal = New-AzADServicePrincipal -Role Owner -Scope "/subscriptio …
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Another object with the same value for property identifierUris already exists.

@@ -289,7 +289,7 @@ try {
$AzureTestPrincipal
} else {
Log "TestApplicationId was not specified; creating a new service principal in subscription '$SubscriptionId'"
$global:AzureTestPrincipal = New-AzADServicePrincipal -Role Owner -Scope "/subscriptions/$SubscriptionId"
$global:AzureTestPrincipal = New-AzADServicePrincipal -Role Owner -Scope "/subscriptions/$SubscriptionId" -DisplayName "test-resources-$($baseName).microsoft.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbp Will this display name cause problems in other clouds that aren't using the microsoft public tenant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will cause functional problems, as it's just a display name, but it would make sense to see if we can grab the suffix out of the tenant/authority host info in the context and use that instead (or just not have the display name include .com).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants