Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change][PR Workflow] pipeline can auto-detect a prior approval #4850

Open
jianyexi opened this issue Dec 1, 2022 · 0 comments
Open

[Breaking Change][PR Workflow] pipeline can auto-detect a prior approval #4850

jianyexi opened this issue Dec 1, 2022 · 0 comments
Assignees
@konrad-jamrozik
Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Milestone
Backlog

Comments

@jianyexi
Copy link

jianyexi commented Dec 1, 2022 •
edited by konrad-jamrozik
Loading

Currently, the swagger breaking change aims to avoid any breaking change against latest stable api-version, so all preview api-version will compare will the latest stable api-version.
For breaking change occurs in a new preview/stable api-version, if exists a prior preview version which already get approval for the breaking change, we might need to figure out a way to avoid report it again.

This issue belongs to a set of related (and possibly at least partially duplicate) issues:
@jianyexi jianyexi self-assigned this Dec 1, 2022
@akning-ms akning-ms added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Dec 2, 2022
@jianyexi jianyexi added this to the 2023-01 milestone Jan 3, 2023
@raych1 raych1 moved this to In Progress in Spec PR Tools Jan 17, 2023
@jianyexi jianyexi modified the milestones: 2023-01, 2023-02 Feb 3, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Mar 10, 2023
@jianyexi jianyexi moved this from In Progress to Todo in Spec PR Tools Mar 13, 2023
@jianyexi jianyexi removed their assignment Mar 13, 2023
@mikekistler mikekistler moved this from Todo to Backlog in Spec PR Tools Apr 4, 2023
@konrad-jamrozik konrad-jamrozik changed the title breaking change pipeline can auto-detect a prior approval Breaking change pipeline can auto-detect a prior approval Apr 6, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Apr 6, 2023
@konrad-jamrozik konrad-jamrozik added the feature-request This issue requires a new behavior in the product in order be resolved. label Apr 6, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Apr 6, 2023
@konrad-jamrozik konrad-jamrozik mentioned this issue Apr 12, 2023
Open
@konrad-jamrozik konrad-jamrozik changed the title Breaking change pipeline can auto-detect a prior approval [Breaking Change] pipeline can auto-detect a prior approval May 12, 2023
@mikekistler mikekistler added the Breaking Changes Improvements to Breaking Changes tooling label Jul 7, 2023
@konrad-jamrozik konrad-jamrozik changed the title [Breaking Change] pipeline can auto-detect a prior approval [Breaking Change][PR Workflow] pipeline can auto-detect a prior approval Jul 11, 2023
@jsquire jsquire modified the milestones: 2023-02, Backlog Jul 14, 2023
This was referenced Jul 7, 2023
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Breaking Changes Improvements to Breaking Changes tooling Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 🚢🎉
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
Backlog
Development

No branches or pull requests
5 participants
@jsquire @konrad-jamrozik @akning-ms @jianyexi @mikekistler