Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to global.json for .NET usage in our templates #5009

Closed
konrad-jamrozik opened this issue Dec 21, 2022 · 0 comments
Closed

Migrate to global.json for .NET usage in our templates #5009

konrad-jamrozik opened this issue Dec 21, 2022 · 0 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Dec 21, 2022

Per @weshaggard's comment here:

We should migrate our usage of .NET to a solution based on global.json, and a pipeline definition like install-dotnet.yml, instead of relying on globals.yml template variables used to install .NET by our archetypes, as e.g. seen in archetype-sdk-tool-dotnet.yml#L70.

Changes to be made

  • As an end result, we don't want to use UseDotNet task anywhere except install-net.yml.
    • At the very least we should migrate all archetype- files to it.
  • We should evaluate every feature used by azure-sdk-for-net install-net.yml for applicability to our case, and if relevant, transplant it.
  • We should consider updating the msbuild-sdks entry already present in our global.json.

Additional details

@konrad-jamrozik konrad-jamrozik self-assigned this Dec 21, 2022
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 21, 2022
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Dec 21, 2022
@konrad-jamrozik konrad-jamrozik removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 21, 2022
@konrad-jamrozik konrad-jamrozik changed the title Migrate to globals.json for .NET usage in our templates Migrate to global.json for .NET usage in our templates Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

1 participant