-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate all usages of task: UseDotNet@2
to template install-net.yml
#5045
Conversation
.azure-pipelines/apiview.yml
Outdated
|
||
- template: /eng/pipelines/templates/steps/install-dotnet.yml | ||
parameters: | ||
DotNetCoreVersion: $(DotNetRuntimeVersion) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pass this here given it aligns with the default? We should consider removing the DotNetRuntimeVersion property completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard @praveenkuttappan the variable is hardcoded to 6.x. It is used in two places: here, and for PublishTestResult@2 / testRunTitle:
- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
testResultsFiles: '**/*.trx'
testRunTitle: 'Windows DotNet $(DotNetRuntimeVersion)'
testResultsFormat: 'VSTest'
mergeTestResults: true
Removing the variable would probably necessitate removing the .NET version from the testRunTitle
, unless you folks have some idea how to pull it into this file out from install-dotnet.yml
or from global.json
.
But I guess it is not a big loss if we remove the version from the test run title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weshaggard @praveenkuttappan OK I went ahead and removed the version variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I would suggest to just remove the version from the title.
…yml`; - remove unused "SkipDotNetInstall" parameter from arcehtype-sdk-tool-dotnet.
83000f7
to
e5fb624
Compare
dfaec5a
to
baa32b7
Compare
task: UseDotNet@2
to template install-net.yml
;task: UseDotNet@2
to template install-net.yml
Overriding, as the APIView error is unrelated:
|
/check-enforcer override |
This PR contributes to:
global.json
for .NET usage in our templates #5009It is a follow-up to:
archetype-sdk-tool-dotnet.yml
BuildAndPackage
job to install .NET SDK viainstall-net.yml
/global.json
#5010It also remove unused
SkipDotNetInstall
parameter from thearchetype-sdk-tool-dotnet
.