Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all usages of task: UseDotNet@2 to template install-net.yml #5045

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

This PR contributes to:

It is a follow-up to:

It also remove unused SkipDotNetInstall parameter from the archetype-sdk-tool-dotnet.

@konrad-jamrozik konrad-jamrozik self-assigned this Jan 4, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Jan 4, 2023

- template: /eng/pipelines/templates/steps/install-dotnet.yml
parameters:
DotNetCoreVersion: $(DotNetRuntimeVersion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pass this here given it aligns with the default? We should consider removing the DotNetRuntimeVersion property completely.

cc @praveenkuttappan

Copy link
Contributor Author

@konrad-jamrozik konrad-jamrozik Jan 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard @praveenkuttappan the variable is hardcoded to 6.x. It is used in two places: here, and for PublishTestResult@2 / testRunTitle:

- task: PublishTestResults@2
  condition: succeededOrFailed()
  inputs:
    testResultsFiles: '**/*.trx'
    testRunTitle: 'Windows DotNet $(DotNetRuntimeVersion)'
    testResultsFormat: 'VSTest'
    mergeTestResults: true

Removing the variable would probably necessitate removing the .NET version from the testRunTitle, unless you folks have some idea how to pull it into this file out from install-dotnet.yml or from global.json.

But I guess it is not a big loss if we remove the version from the test run title?

Copy link
Contributor Author

@konrad-jamrozik konrad-jamrozik Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I would suggest to just remove the version from the title.

Konrad Jamrozik added 2 commits January 8, 2023 21:10
…yml`;

- remove unused "SkipDotNetInstall" parameter from arcehtype-sdk-tool-dotnet.
@konrad-jamrozik konrad-jamrozik changed the title Migrate all usages of task: UseDotNet@2 to template install-net.yml; Migrate all usages of task: UseDotNet@2 to template install-net.yml Jan 9, 2023
@konrad-jamrozik
Copy link
Contributor Author

Overriding, as the APIView error is unrelated:

[xUnit.net 00:00:21.32]     APIViewIntegrationTests.ReviewManagerTests.AddRevisionAsync_Computes_Headings_Of_Sections_With_Diff_A [FAIL]
  Failed APIViewIntegrationTests.ReviewManagerTests.AddRevisionAsync_Computes_Headings_Of_Sections_With_Diff_A [2 s]
  Error Message:
   Microsoft.Azure.Cosmos.CosmosException : Response status code does not indicate success: NotFound (404); Substatus: 1013; ActivityId: 6ac47a94-9bf8-43d6-848a-d7e4e9e07b32; Reason: (Collection is not yet available for read. Please retry in some time.

@praveenkuttappan FYI

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants