Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra newline at the end of the file #1106

Merged
1 commit merged into from
Oct 19, 2020
Merged

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Oct 19, 2020

This is a follow up PR (#1103) which introduced extra new line at the end of the file.
Local testing indicates we added new line at end.
Checked the github io, and it does not bring too many differences.
E.g.
After PR,
https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.22/index.html
Before PR,
https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.20/index.html

@sima-zhu sima-zhu requested a review from a team as a code owner October 19, 2020 17:48
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Oct 19, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit db47094 into Azure:master Oct 19, 2020
@sima-zhu sima-zhu deleted the no_new_line branch October 19, 2020 20:01
benbp pushed a commit that referenced this pull request Dec 1, 2020
This is a follow up PR (#1103) which introduced extra new line at the end of the file. 
Local testing indicates we added new line at end.
Checked the github io, and it does not bring too many differences.
E.g.
After PR,
https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.22/index.html
Before PR,
https://azuresdkdocs.blob.core.windows.net/$web/javascript/azure-template/1.0.9-beta.20/index.html
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants