APiView changes to add package name and version for python in review #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
VersionString and Version properties should not be set by parser. This is set by API view tool itself. Change in this PR is to set package name and package version |
praveenkuttappan
force-pushed
the
feature/python_apiview_changes
branch
from
ae37649 to
d83c9ca
Compare
mitchdenny
reviewed
Nov 25, 2020
| self.Version = pkg_version | ||
| self.VersionString = ver_string | ||
| self.Version = 0 | ||
| self.VersionString = "" |
There was a problem hiding this comment.
Was this intentional? Wouldn't we want this meta-data?
There was a problem hiding this comment.
Yup. APIView tool sets these two fields when it parses ast.
mitchdenny
approved these changes
Nov 25, 2020
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to include python package name and version in review to support finding a review for a package.