-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back to smoke-test before doc publishing error gets fixed. #1222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Additional context for anyone reading this PR: The issue isn't the submission of PRs to master
. The issue is that when CI writes to master
(instead of smoke-test
), there is a publishing failure that wasn't resolvable with information we had. Manual queues of publishing of that same commit worked just fine.
The following pipelines have been queued for testing: |
Change looks good but I'm curious what our plan is to get these changes into master now? I thought we were trying to eliminate the smoke-test branch. |
@scbedd has explained in comments as well. |
The plan is definitely to eliminate the smoke-test branch. We just haven't swapped yet because when CI writes to |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1222 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
No description provided.