Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks to New-TestResources readme #1351

Merged
3 commits merged into from
Feb 1, 2021

Conversation

christothes
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

eng/common/TestResources/README.md Outdated Show resolved Hide resolved
eng/common/TestResources/README.md Outdated Show resolved Hide resolved
@weshaggard weshaggard requested a review from benbp January 29, 2021 01:34
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@christothes
Copy link
Member Author

@benbp Should I override check enforcer on this?

@benbp
Copy link
Member

benbp commented Jan 29, 2021

@christothes you need to click through the pipeline and manually approve a few things. It needs to: create sync PRs for your change against all the repos, then you have to wait until all those are green (and approve them yourself), then approve the pipeline against which will merge them.

You can see the workflow docs here: https://github.com/Azure/azure-sdk-tools/blob/master/doc/common/common_engsys.md#workflow

@christothes
Copy link
Member Author

@benbp The js pipeline is failing for apparently unrelated issues. I attempted to re-run a few times just to check if it was transient.

@weshaggard
Copy link
Member

@christothes for the JS case if it the failure is unrelated just override check-enforcer and merge manually.

BTW it looks like you manually merged l the sync PR's. For future reference you only need to approve each of those PR's and then the automation in the "azure-sdk-tools - sync - eng-common" pipeline will attempt to merge all the PRs.

@ghost
Copy link

ghost commented Feb 1, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ecd61a9 into Azure:master Feb 1, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants