-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sub directory for artifact location #1364
Support sub directory for artifact location #1364
Conversation
The following pipelines have been queued for testing: |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
The following pipelines have been queued for testing: |
@weshaggard : Can you please have a look and approve this when you get a chance? I have made the change per our discussion to use a separate param for config path |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
@@ -83,6 +84,10 @@ else | |||
|
|||
$FoundFailure = $False | |||
$pkgInfoPath = Join-Path -Path $ArtifactPath "PackageInfo" | |||
if ($ConfigFileDir) | |||
{ | |||
$pkgInfoPath = Join-Path -Path $ConfigFileDir "PackageInfo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you weren't understanding my other request. If ConfigFileDir is passed I'd expect it to be the exact directory where the config files exists and so we shouldn't append the PackageInfo path to those.
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Java API review create step requires additional artifact sub directory param. This will help in using generic artifact path to look for config files.