Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lease to runs. #1515

Merged
4 commits merged into from
Apr 12, 2021
Merged

Add lease to runs. #1515

4 commits merged into from
Apr 12, 2021

Conversation

mitchdenny
Copy link
Contributor

This PR adds a PowerShell script that adds a retention lease to a pipeline run. Because you can only have one lease it first checks to see if a lease exists already, and if it does it removes it and adds it again for the specified validity period (there doesn't appear to be a patch operation according to the REST API docs).

@mitchdenny mitchdenny requested a review from a team as a code owner March 24, 2021 05:20
@mitchdenny mitchdenny self-assigned this Mar 24, 2021
@mitchdenny mitchdenny added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Mar 24, 2021
@mitchdenny
Copy link
Contributor Author

Closes: Azure/azure-sdk#1059

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Apr 12, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c09e073 into Azure:master Apr 12, 2021
@mitchdenny mitchdenny deleted the add-lease-to-runs branch April 12, 2021 00:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants