Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable release date check #1763

Merged
2 commits merged into from
Jun 30, 2021
Merged

Conversation

praveenkuttappan
Copy link
Member

@praveenkuttappan praveenkuttappan commented Jun 30, 2021

Disable release date check when enforcing API review status. Java package got released without API approval even though release date is present. As per the analysis so far, change log parser didn't find the release date even though it was present so API check didn't enforce it. As a first step, disabling this new check to enforce API approval.

Update: Identified root cause and updated PR with actual fix to get the release date in package properties file. updated change is not disabling this check.

@praveenkuttappan praveenkuttappan requested a review from a team as a code owner June 30, 2021 01:40
@praveenkuttappan praveenkuttappan self-assigned this Jun 30, 2021
@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Jun 30, 2021
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Jun 30, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 09ac2cb into Azure:main Jun 30, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants