-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle assembly already loaded errors in deploy stress test script #2027
Conversation
/azp run Stress Test Release |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
The following pipelines have been queued for testing: |
@@ -21,8 +21,8 @@ $ErrorActionPreference = 'Stop' | |||
$FailedCommands = New-Object Collections.Generic.List[hashtable] | |||
|
|||
. (Join-Path $PSScriptRoot "../Helpers" PSModule-Helpers.ps1) | |||
Install-ModuleIfNotInstalled "powershell-yaml" "0.4.1" | Import-Module | |||
Install-ModuleIfNotInstalled "az" "6.4.0" | Import-Module | |||
Install-ModuleIfNotInstalled "powershell-yaml" "0.4.1" | Import-Module -ErrorAction Continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a common error we should consider adding a helper function for importing.
Is this a real problem? We should only be importing it if it isn't already loaded. |
@weshaggard I'm not quite sure what's going on here, or why it seems to be only affecting this pipeline and not ALL pipelines that use this. I thought of this as a short term workaround but I really would like to understand the root issue here. |
I'm not sure why it isn't correctly detecting the loaded module but it looks like you aren't using this in a normal powershell step but instead as part of some Azure CLI step is there a reason for that? |
Now I'm not so sure why I even added this as a dependency at all. We don't use the Az cmdlets in this script... |
@weshaggard updated the PR to check for azure cli not I have been using the Azure CLI step in order to pass through the azure service connection to the azure cli usage in the script. |
The following pipelines have been queued for testing: |
/azp run Stress Test Release |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
2bdfa96
to
c3678e0
Compare
The following pipelines have been queued for testing: |
c3678e0
to
09e8868
Compare
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
/check-enforcer override |
This issue has been showing up recently: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1103685&view=logs&j=38a05975-7697-5434-099a-d7b3d4012883&t=b1e71580-9408-50be-13a0-b0783b8cb008&l=57