Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stress-test-resources file naming to avoid live test auto-discovery #2039

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Use stress-test-resources file naming to avoid live test auto-discovery #2039

merged 3 commits into from
Sep 27, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Sep 24, 2021 •
edited
Loading

Live test auto-discovery of ARM/Bicep templates (via New-TestResources.ps1) is picking up the stress test templates since it looks recursively for files with the naming pattern test-resources.<ext>. This renames the stress test resources file to stress-test-resources.<ext> to avoid discovery.

@yunhaoling @richardpark-msft @kasobol-msft

@benbp benbp requested a review from a team as a code owner September 24, 2021 18:27
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Sep 24, 2021
@benbp benbp self-assigned this Sep 24, 2021
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Sep 24, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@yunhaoling yunhaoling mentioned this pull request Sep 24, 2021
Closed
@ghost
Copy link

ghost commented Sep 27, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@benbp
Copy link
Member Author

benbp commented Sep 27, 2021

/check-enforcer override

@benbp benbp merged commit 669998c into Azure:main Sep 27, 2021
@benbp benbp deleted the benbp/stress-test-resources-template branch September 27, 2021 19:03
@benbp benbp mentioned this pull request Sep 27, 2021
Merged
ghost pushed a commit that referenced this pull request Sep 27, 2021
@benbp
Bump stress-test-addons chart version to 0.1.7 (#2042)
4849d89 
Updating stress-test-addons helm chart version with changes from #2039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbp @azure-sdk @weshaggard