Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest released version to prepare prerelease #2130

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add latest released version to prepare prerelease #2130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions eng/common/scripts/Prepare-Release.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,15 @@ else
$releaseDateString = $ParsedReleaseDate.ToString("MM/dd/yyyy")
$month = $ParsedReleaseDate.ToString("MMMM")

Write-Host
Write-Host "Assuming release is in $month with release date $releaseDateString" -ForegroundColor Green
if (Test-Path "Function:GetExistingPackageVersions")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of querying the package manager we should consider using the tags? If so we can move some of the tag helpers from https://github.com/Azure/azure-sdk/blob/main/eng/scripts/PackageVersion-Helpers.ps1#L3 into the tools repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it possible for tags to exist for packages that eventually failed to publish to the package manager?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is possible. I guess our package index script also verifies that the package link exists before it updates the package version. I wonder if we can just have a default implementation that uses the tags because that should be common and consistent across repos but allow for an override or verification for the versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using this function but reverting to use the git tag where this function is not implemnted? Since it seems that this will be more reliable than git tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think eventually that might be reasonable but at this point since it is just for informational purposes in Prepare-release, it is probably not worth the effort. We can just not output this information if the function doesn't exist.

{
$releasedVersions = GetExistingPackageVersions -PackageName $packageProperties.Name -GroupId $packageProperties.Group
$latestReleasedVersion = $releasedVersions[$releasedVersions.Count - 1]
chidozieononiwu marked this conversation as resolved.
Show resolved Hide resolved
Write-Host "Latest released version: ${latestReleasedVersion}" -ForegroundColor Green
}

$currentProjectVersion = $packageProperties.Version

$newVersion = Read-Host -Prompt "Input the new version, or press Enter to use use current project version '$currentProjectVersion'"

if (!$newVersion)
Expand Down