[Test-Proxy] Fix default startup location in docker-start-proxy.ps1, Update windows tool initialize
#2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following pipelines have been queued for testing: |
scbedd
added
the
Central-EngSys
scbedd
changed the title
docker-start-proxy.ps1docker-start-proxy.ps1, Update windows tool initialize
|
The following pipelines have been queued for testing: |
This was referenced Nov 17, 2021
HarshaNalluru
approved these changes
Nov 17, 2021
28 tasks
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can use script located at
eng/common/testproxy/docker-start-proxy.ps1to start and stop a default docker configuration.There is a second argument,
TargetFolder, that is used to change the folder will be bound to the volume of the new docker container.The default used to be
".", so that the current folder would bind to the volume.This PR changes the behavior so that if no target folder is provided, it will instead default to root of the containing repository. The ability to provide this context is unchanged.