-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read the ms.service value from csv metadata #2910
Conversation
The following pipelines have been queued for testing: |
# Normalize service name "Key Vault" -> "keyvault" | ||
$service = $PackageInfo.ServiceDirectory.ToLower() | ||
if ($PackageMetadata -and $PackageMetadata.MSDocService) { | ||
# Use MSDocService in csv metadata to override the service directory | ||
# TODO: Use taxonomy for service name -- https://github.com/Azure/azure-sdk-tools/issues/1442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO still interesting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they can provide useful APIs, then align with their system is the most accurate way to go and minimize human efforts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggestions but otherwise looks good.
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Our original
ms.service
assign value as follows:ServiceName
exists, then NormalizeKey Vault - > keyvault
The proposal:
MSDocService
exists, then use the value directly. PM or service owner will update this to the right valueTesting pipeline on redis:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1432407&view=results
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1432410&view=results