Fixed not filter out group id issue. #2939
Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
sima-zhu
force-pushed
the
check_group_id
branch
from
192ba4e
to
78883ba
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| }) | ||
| $fullMetadata = Get-CSVMetadata | ||
| $metadata = @() | ||
| foreach($metadataEntry in $fullMetadata) { |
There was a problem hiding this comment.
Should we instead loop through the onboardedPackages and find the matching metadata instead?
There was a problem hiding this comment.
We can build a package look via GetPackageLookup like we are doing below.
There was a problem hiding this comment.
onboardedPackages is a lookup map, and metadata is csv array. So this is an efficiency comparison.
The script is used by python, js, java already. I'd prefer to make few changes to avoid mess up the work in progress.
There was a problem hiding this comment.
OK Yes I guess we are just trying to find the intersection of the 2 sets so either direction works. I will leave this review up to @danieljurek the change but I if feels like we are reading the metadata from the csv multiple times in this function. Just potentially an optimization to be had.
sima-zhu
added
the
Central-EngSys
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
sima-zhu
force-pushed
the
check_group_id
branch
from
c1c7d04
to
ede0121
Compare
sima-zhu
force-pushed
the
check_group_id
branch
from
ede0121
to
d3d6fd9
Compare
sima-zhu
force-pushed
the
check_group_id
branch
from
e5535c0
to
9184c18
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Problem:
Java toc did not filter out package not onboarding because we did not have group id checking.
Docs.MS does not have "com.microsoft.azure:azure-core" (track 1 azure-core), but it got displayed in toc generation.
The PR is to fix this issue by adding group id check.
Java PR: Azure/azure-sdk-for-java#27782
Tested in local, no track 1 azure core in toc anymore.