-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support creating test resources based on logged in user #7580
Support creating test resources based on logged in user #7580
Conversation
d06a10e
to
aaa5959
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me but I'm going to defer to @benbp who has more history with this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a parameter name change
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7580 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: jolov <jolov@microsoft.com>
The way that this can be integrated into language test frameworks is by assuming that if no client secret is populated, a user credential should be created instead of a client secret credential.
Also, downstream test-resources templates should remove testApplicationSecret from the parameter list to avoid being prompted for it (assuming it is not actually necessary).