Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape parentheses in includes to fix issues in publishing #9177

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented Oct 15, 2024

Includes whitespace changes

Fixes #5433

Testing. Left is the live site, right is the same page with escaped parentheses in the filename:

image

@danieljurek danieljurek requested a review from a team as a code owner October 15, 2024 20:45
@danieljurek danieljurek self-assigned this Oct 15, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Oct 17, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9177 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
@danieljurek danieljurek merged commit aedce14 into main Oct 17, 2024
12 checks passed
@danieljurek danieljurek deleted the djurek/service-level-automation-escape-includes branch October 17, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Service Level Overview pages should not have parens in the filenames
3 participants