Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish docs cleanup #9331

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Finish docs cleanup #9331

merged 2 commits into from
Nov 7, 2024

Conversation

JimSuplizio
Copy link
Member

The docker-pull-image.yml template was only used by update-docsms-metadata.yml and even then, only Java, JS and Python. All of the aforementioned languages now use the "2docfx" tools do docs generation verification and no longer require the docker images.

The scripts that took the docker image id as a parameter have had that parameter removed and no longer pass that option to any functions/function pointers.

@danieljurek removed the docker images, themselves.

@JimSuplizio JimSuplizio self-assigned this Nov 5, 2024
@JimSuplizio JimSuplizio requested a review from a team as a code owner November 5, 2024 20:07
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 7, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9331 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>
@JimSuplizio JimSuplizio merged commit 61157fd into Azure:main Nov 7, 2024
16 checks passed
@JimSuplizio JimSuplizio deleted the FinishDocsCleanup branch November 7, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants