Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board Review: Azure.ResourceManager.Help Namespace Review (Microsoft.Help Resource Provider) #5817

Closed
BharathaAravind opened this issue Mar 21, 2023 · 11 comments
Assignees
Labels
architecture board-review Request for an Architectural Board Review

Comments

@BharathaAravind
Copy link
Member

BharathaAravind commented Mar 21, 2023

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.

The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.

Please reference our review process guidelines to understand what is being asked for in the issue template.

To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together. In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.

For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

About the Service

About the client library

  • Name of the client library:
  • Languages for this review:

• Java
Resource Management - Help
azure-resourcemanager-help
API View Link: https://apiview.dev/Assemblies/Review/73135cd3a34243349ee51728aad80224

• JavaScript
Resource Management - Help
@azure/arm-help
API View Link: https://apiview.dev/Assemblies/Review/d360d9e658664b20ad829dc20a6c45a5

• Go/Golang
Resource Management - Help
sdk/resourcemanager/help/armhelp
API View link: Failed to generate (Working with pr reviewer. Look at swagger pr for more details)

• .NET (Future)
Resource Management - Help
Azure.ResourceManager.Help
API View Link: N/A

• Swagger
API view link: https://apiview.dev/Assemblies/Review/a38db001941d4debac155a8202e88dff

Thank you!

@BharathaAravind
Copy link
Member Author

BharathaAravind commented Mar 21, 2023

@ronniegeraghty / @kyle-patterson please review this and rename title API Review/API Sign Off to management and/or client libraries Introducing Microsoft.Help approval

@BharathaAravind BharathaAravind changed the title Board Review: Microsoft.Help MGMT Plane Namespace Review Board Review: Azure.ResourceManager.Help Namespace Review (Microsoft.Help Resource Provider) Mar 21, 2023
@ronniegeraghty
Copy link
Member

@BharathaAravind,
I believe we already reviewed and approved MGMT SDK Namespaces for this spec in this issue: https://github.com/Azure/azure-sdk-pr/issues/854

@BharathaAravind
Copy link
Member Author

@ronniegeraghty Yeah I added the link to previously approved spec in the description. After discussing internally, we would like to do the review again and propose few more options other than HelpRp. Ex: Help, AzureHelp, HelpApi, AzHelp, ArmHelp etc

@KrzysztofCwalina
Copy link
Member

KrzysztofCwalina commented Mar 21, 2023

To me just "Help" is too generic. Coudl we call it SelfHelp or SelfDiagnostics or Troubleshooting?

@ronniegeraghty
Copy link
Member

ronniegeraghty commented Mar 28, 2023

After an email thread here are the agreed upon namespaces for each language:

  • .NET: Azure.ResourceManager.SelfHelp
  • Java: azure-resourcemanager-selfhelp (com.azure.resourcemanager.selfhelp)
  • Go: sdk/resourcemanager/selfhelp/armselfhelp
  • JavaScript: @azure/arm-selfhelp
  • Python: azure-mgmt-selfhelp

The namespaces above have been provided to our architect team and are being reviewed.

@JeffreyRichter
Copy link
Member

Go should be sdk/resourcemanager/selfhelp/armselfhelp

@BharathaAravind
Copy link
Member Author

@JeffreyRichter - I think it is a typo. For Go, it will follow the default format like you suggested.

sdk/resourcemanager/selfhelp/armselfhelp

@ronniegeraghty
Copy link
Member

@JeffreyRichter & @BharathaAravind I updated my comment with the namespaces to reflect your comments.

@BharathaAravind
Copy link
Member Author

BharathaAravind commented Apr 4, 2023

@ronniegeraghty - Can we consider this as our approved namespaces based on the email thread conversation?

@ronniegeraghty
Copy link
Member

@ronniegeraghty - Can we consider this as our approved namespaces based on the email thread conversation?

At EOB today the architect's week to object to the names will be up and the names will be considered approved. I'll comment again when the approval is final.

@ronniegeraghty
Copy link
Member

The following namespaces are approved:

.NET: Azure.ResourceManager.SelfHelp
Java: azure-resourcemanager-selfhelp (com.azure.resourcemanager.selfhelp)
Go: sdk/resourcemanager/selfhelp/armselfhelp
JavaScript: @azure/arm-selfhelp
Python: azure-mgmt-selfhelp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review
Projects
None yet
Development

No branches or pull requests

5 participants