-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Board Review: Azure.ResourceManager.Help Namespace Review (Microsoft.Help Resource Provider) #5817
Comments
@ronniegeraghty / @kyle-patterson please review this and rename title API Review/API Sign Off to management and/or client libraries Introducing Microsoft.Help approval |
@BharathaAravind, |
@ronniegeraghty Yeah I added the link to previously approved spec in the description. After discussing internally, we would like to do the review again and propose few more options other than HelpRp. Ex: Help, AzureHelp, HelpApi, AzHelp, ArmHelp etc |
To me just "Help" is too generic. Coudl we call it SelfHelp or SelfDiagnostics or Troubleshooting? |
After an email thread here are the agreed upon namespaces for each language:
The namespaces above have been provided to our architect team and are being reviewed. |
Go should be sdk/resourcemanager/selfhelp/armselfhelp |
@JeffreyRichter - I think it is a typo. For Go, it will follow the default format like you suggested. sdk/resourcemanager/selfhelp/armselfhelp |
@JeffreyRichter & @BharathaAravind I updated my comment with the namespaces to reflect your comments. |
@ronniegeraghty - Can we consider this as our approved namespaces based on the email thread conversation? |
At EOB today the architect's week to object to the names will be up and the names will be considered approved. I'll comment again when the approval is final. |
The following namespaces are approved: .NET: |
Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together. In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline
About the Service
About the client library
• Java
Resource Management - Help
azure-resourcemanager-help
API View Link: https://apiview.dev/Assemblies/Review/73135cd3a34243349ee51728aad80224
• JavaScript
Resource Management - Help
@azure/arm-help
API View Link: https://apiview.dev/Assemblies/Review/d360d9e658664b20ad829dc20a6c45a5
• Go/Golang
Resource Management - Help
sdk/resourcemanager/help/armhelp
API View link: Failed to generate (Working with pr reviewer. Look at swagger pr for more details)
• .NET (Future)
Resource Management - Help
Azure.ResourceManager.Help
API View Link: N/A
• Swagger
API view link: https://apiview.dev/Assemblies/Review/a38db001941d4debac155a8202e88dff
Thank you!
The text was updated successfully, but these errors were encountered: