Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] Generate Fluent Lite from help#package-2023-01-01-preview #34708

Closed

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Apr 28, 2023

[Automation] Generate Fluent Lite from help#package-2023-01-01-preview

Release request: https://github.com/Azure/sdk-release-request/issues/4035
Archboard review: Azure/azure-sdk#5817

@haolingdong-msft
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@haolingdong-msft
Copy link
Member

/azp run java - selfhelp - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator Author

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-selfhelp


## 1.0.0-beta.1 (2023-04-28)

- Azure Resource Manager selfhelp client library for Java. This package contains Microsoft Azure SDK for selfhelp Management SDK. Help RP provider. Package tag package-2023-01-01-preview. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the service name(self-help?). Though GO is using selfhelp too, guess that's fine...
https://github.com/Azure/azure-sdk-for-go/blob/3bdc6234b14b48903e1b6c26ef15063c720c4e82/sdk/resourcemanager/selfhelp/armselfhelp/README.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure/azure-sdk#5817 Please refer to this archborad review issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I meant the manager name and service description in README. e.g. SelfHelpManager. You can ignore this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will add the pr to the release request issue and let service team decide.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, manager name seems better be SelfHelp...

@haolingdong-msft
Copy link
Member

create new one with the updated service name: #34913, close this one.

@azure-sdk azure-sdk deleted the fluent-lite-generation-2735351 branch October 19, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants