Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

tell users they can't go higher than 5 minutes #202

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

paulgmiller
Copy link
Member

@paulgmiller paulgmiller commented Jan 7, 2021

Today if you pass SubscriptionWithLockDuration a duration > 5 minutes you will just never get messages.
Here I am attempting to fail faster.
Another alternative would be to have the put fail.

Copy link

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serbrech
Copy link
Member

ping @jhendrixMSFT

@jhendrixMSFT
Copy link
Member

Could you update the version in namespace.go please? It should be v0.10.9. I'll then merge and tag.

@paulgmiller
Copy link
Member Author

@jhendrixMSFT thanks pushed.

@jhendrixMSFT jhendrixMSFT merged commit 12810d6 into Azure:master Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants