This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
fix lock renewal test to take into account amqp flow #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amqp now takes message dispostion into account to adjust the flow this means that no credits are provided to the sender until a disposition is sent for a given message. previous test handled messages concurrently without completing them and this won't work anymore, unless the prefetch is set higher.
serbrech
changed the title
jhendrixMSFT
approved these changes
Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-amqp now takes message dispostion into account to adjust the flow
this means that no credits are provided to the sender
until a disposition is sent for a given message.
previous test handled messages concurrently without completing them
and this won't work anymore, unless the prefetch is set higher.