Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Retry refreshing credentials #245

Merged
merged 2 commits into from
Aug 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change Log

## `v0.10.16`

- fixed an issue where links weren't being closed when retrying
- fixed an issue where auto-refreshing of claims would exit due to a transient error

## `v0.10.15`

- fix issue where deferring a message could result us encoding it incorrectly and sending the sequence
Expand Down
18 changes: 14 additions & 4 deletions namespace.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const (
//`

// Version is the semantic version number
Version = "0.10.11"
Version = "0.10.16"

rootUserAgent = "/golang-service-bus"

Expand Down Expand Up @@ -266,10 +266,20 @@ func (ns *Namespace) negotiateClaim(ctx context.Context, client *amqp.Client, en
case <-time.After(15 * time.Minute):
refreshCtx, span := ns.startSpanFromContext(refreshCtx, "sb.namespace.negotiateClaim.refresh")
defer span.End()
if err := cbs.NegotiateClaim(refreshCtx, audience, client, ns.TokenProvider); err != nil {
// refresh credentials until it succeeds
for {
err := cbs.NegotiateClaim(refreshCtx, audience, client, ns.TokenProvider)
if err == nil {
break
}
// the refresh failed, wait a few seconds then try again
tab.For(refreshCtx).Error(err)
// if auth failed cancel auto-refresh
cancel()
select {
case <-refreshCtx.Done():
break
case <-time.After(5 * time.Second):
// retry
}
}
}
}
Expand Down